Skip to content

Conversation

@AndersDJohnson
Copy link
Contributor

For copying, it doesn't make sense to push relations to the new object if existing list may not be empty, e.g. with a default value, or with an existing model using copyTo from #14.

@AndersDJohnson
Copy link
Contributor Author

Looks like the tests are stuck. I'll have to fix before this should be merged.

@AndersDJohnson
Copy link
Contributor Author

Fixed by using setObjects instead of set in 449d9f7. Ready for merge.

@lazybensch
Copy link
Owner

yes this has bitten me at some point aswell, thx for the PR

actually, you might wanna check out #11. I'm using this one in our production app and except for circular dependency checking (which i haven't had the time yet) it does not have most of the issues the current master has.

lazybensch added a commit that referenced this pull request Nov 10, 2015
@lazybensch lazybensch merged commit 9198594 into lazybensch:master Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants