Specify API-level search timeout to reduce hard timeout errors. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to look into whether the metrics can be updated when the new type of timeout produces incomplete results. |
jackrobison
requested changes
Aug 24, 2022
| @@ -59,7 +59,7 @@ async def start(self) -> bool: | |||
| return False | |||
| hosts = [{'host': self._elastic_host, 'port': self._elastic_port}] | |||
| self.sync_client = AsyncElasticsearch(hosts, timeout=self.sync_timeout) | |||
| self.search_client = AsyncElasticsearch(hosts, timeout=self.search_timeout) | |||
| self.search_client = AsyncElasticsearch(hosts, timeout=self.search_timeout+1) | |||
There was a problem hiding this comment.
What was the +1 for? Can this be removed?
There was a problem hiding this comment.
If the transport timeout is less than (or possibly equal to) the API timeout, then we will likely continue to get hard timeout errors. Bumping it by 1 is a way of pushing it out beyond the API timeout. The API timeout should trigger first, and we get partial results.
I could make the API timeout some fraction of the transport timeout...
This reverts commit 28c711e.
bump in different way.
shyba
approved these changes
Sep 12, 2022
jackrobison
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #71 for context.
#71 (comment)
The effect should be that the ES server side will notice that time budget has run out. Then it should return partial results without an error. This may make things smoother for clients, though it means that results might not be complete until performance blip goes away.
I've run some of the lbry-sdk integration tests (tests/integration/claims).