-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving prefix-string parsing (fixes #2339) #2511
Conversation
Thanks! This PR looks good. Can you write a test that failed (or gave a misleading error message) in master, and now works (gives a good error message)? If it is just a better error message, you can put it into |
83b4616
to
daae9dc
Compare
Added the tests. |
This looks great, thanks for fixing it and adding tests. I left some minor comments to fix.
Use |
You have to update reference tests via |
Thanks I noticed a little late. 😅 |
Either polish the commits to a few logical commits and rebase, or just leave it and I'll squash and merge it. |
I think you can just squash and merge it. I think I would probably mess things up with the rebase. |
Fixes #2339
Modifies how prefix-strings is parsed and tokenized.
Now the compiler gives a syntax error when encountering a identifier(not a prefix) followed by a string literal.