DEV: Sync libasr with LFortran #2827
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
reviewed
Feb 26, 2025
| strings_to_be_deallocated.p = strings_to_be_deallocated_copy; | ||
| } | ||
|
|
||
| void visit_ForEach(const ASR::ForEach_t &x) { |
There was a problem hiding this comment.
Not sure if this function / node was removed? It might be a specific node in LPython.
|
I think there was work in LPython to get various dicts and lists operations working, so it would be good to keep that if we can. But I think it is more important to sync, and keep it synced after that, so if it is difficult, we can temporarily remove it, and try to add it back later (the proper way: in LFortran first, then update a submodule). |
assem2002
reviewed
Feb 26, 2025
| @@ -45,23 +45,23 @@ stmt | |||
| | GoToTarget(int id, identifier name) | |||
| | If(expr test, stmt* body, stmt* orelse) | |||
| | IfArithmetic(expr test, int lt_label, int eq_label, int gt_label) | |||
| | Print(expr* values, expr? separator, expr? end) | |||
There was a problem hiding this comment.
I think end and separator are used in python syntax.
assem2002
reviewed
Feb 26, 2025
| if (x.m_separator) { | ||
| this->visit_expr(*x.m_separator); | ||
| separator = src; | ||
| separator = "\" \""; | ||
| //HACKISH way to handle print refactoring (always using stringformat). | ||
| // TODO : Implement stringformat visitor. |
There was a problem hiding this comment.
let's keep combination of this as we should keep separator and end memebers.
assem2002
reviewed
Feb 26, 2025
Comment on lines
-1190
to
-1196
| if (x.m_end) { | ||
| this->visit_expr(*x.m_end); | ||
| tmp_gen += "\%s\""; | ||
| v.push_back(src); | ||
| } else { | ||
| tmp_gen += "\\n\""; | ||
| } |
There was a problem hiding this comment.
as well as keeping this.
czgdp1807
force-pushed
the
libasr_sync
branch
2 times, most recently
from
09d9ff3 to
8045c16
Compare
czgdp1807
force-pushed
the
libasr_sync
branch
from
ce689a9 to
ede6e7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.