Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prop types dependency #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pintocarlos
Copy link

  • Adds prop-types npm package.
  • Deprecates usage of React.PropTypes from 'react' npm package.
  • Adds missing .gitignore file with node_modules ignore

@dariocravero
Copy link

@ldn0x7dc will you merge these and do a release? Otherwise @pintocarlos, how about forking this and releasing it?

@pintocarlos
Copy link
Author

@dmueller39
I also added a PR for that dependency at the time of creating this issue:
ldn0x7dc/react-native-view-transformer#14

@dmueller39
Copy link

@pintocarlos Ah! Looks like this needs to wait until that is merged + released so the dependency can be updated?

@dmueller39
Copy link

@brentvatne @dabit3 @ide Hey react-native-community folks, this is a semi popular repo that seems to have been orphaned by its maintainer. (there are several others as well) Would it be uncool to ask that it get forked on react-native-community?

It would be nice to have a process for this, because I've been running into a lot of issues with libraries that no one is maintaining anymore.

@ide
Copy link

ide commented Oct 24, 2017

@dmueller39 The fact that this project is unmaintained is a strong reason not to add it to react-native-community IMO.

I’d recommend forking the project if you need custom changes yourself, sponsoring work on it, and building a new community of contributors if it’s actually important to you.

@brentvatne
Copy link

also, this should be re-written using react-native-gesture-handler

@dmueller39
Copy link

Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants