-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prop types dependency #30
base: master
Are you sure you want to change the base?
Update prop types dependency #30
Conversation
pintocarlos
commented
Aug 30, 2017
- Adds prop-types npm package.
- Deprecates usage of React.PropTypes from 'react' npm package.
- Adds missing .gitignore file with node_modules ignore
…sage of PropTypes from react npm module.
@ldn0x7dc will you merge these and do a release? Otherwise @pintocarlos, how about forking this and releasing it? |
@pintocarlos This repo has a dependency that needs to b updated as well https://github.com/ldn0x7dc/react-native-view-transformer |
@dmueller39 |
@pintocarlos Ah! Looks like this needs to wait until that is merged + released so the dependency can be updated? |
@brentvatne @dabit3 @ide Hey react-native-community folks, this is a semi popular repo that seems to have been orphaned by its maintainer. (there are several others as well) Would it be uncool to ask that it get forked on react-native-community? It would be nice to have a process for this, because I've been running into a lot of issues with libraries that no one is maintaining anymore. |
@dmueller39 The fact that this project is unmaintained is a strong reason not to add it to react-native-community IMO. I’d recommend forking the project if you need custom changes yourself, sponsoring work on it, and building a new community of contributors if it’s actually important to you. |
also, this should be re-written using react-native-gesture-handler |
Thanks for the feedback. |