Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Duplicate room button does not copy everything #185 #228

Merged
merged 2 commits into from
Dec 18, 2023
Merged

fix: Duplicate room button does not copy everything #185 #228

merged 2 commits into from
Dec 18, 2023

Conversation

frojo
Copy link
Contributor

@frojo frojo commented Jul 30, 2023

Description

bugfix

@frojo frojo requested a review from le-doux as a code owner July 30, 2023 19:41
@le-doux le-doux changed the base branch from main to version-8-8 December 18, 2023 22:56
le-doux
le-doux approved these changes Dec 18, 2023
View reviewed changes
Copy link
Owner

@le-doux le-doux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a small tweak to make sure we're using the new array of items you added but otherwise looks good :)

@le-doux le-doux merged commit cf409a9 into le-doux:version-8-8 Dec 18, 2023
le-doux added a commit that referenced this pull request Dec 19, 2023
@le-doux @vaasut
@seleb @pancelor
Version 8.8 (#246)
8691e84 
* Add information for uploadToItch.md (#235)

* Add information for uploadToItch.md

* Update docs/docs/faq/uploadToItch.md

Co-authored-by: Sean S. LeBlanc <[email protected]>

* Fix typos in docs/docs/faq/uploadToItch.md

Co-authored-by: Sean S. LeBlanc <[email protected]>

* Add closing tag for <img> to uploadToItch.md

Fix React Syntax Error : Expected corresponding JSX closing tag for <img>

---------

Co-authored-by: Sean S. LeBlanc <[email protected]>

* fix ClearCache tile memory leak (#232)

* fix off-by-one allocating

given these blocks:

4: occupied
5: occupied
6: undefined

and this call:
`_allocate({ start: 4, max: 2 })`

you would expect the allocation to fail and return null.
before this commit, this situation instead would allocate block 6

I don't know if this had any adverse effects; I just noticed it while
working on related stuff

* make sure ClearCache() deletes tile memory

fixes #230

* fix: Duplicate room button does not copy everything #185 (#228)

* fix: Duplicate room button does not copy everything #185

* use copied items array instead of slice

---------

Co-authored-by: Adam Le Doux <[email protected]>

* brazilian portuguese translation

---------

Co-authored-by: vaasut <[email protected]>
Co-authored-by: Sean S. LeBlanc <[email protected]>
Co-authored-by: pancelor <[email protected]>
Co-authored-by: fran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@le-doux le-doux le-doux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frojo @le-doux