Write Guide for lockedDoor.md #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write step by step guide with images explaining how to create a locked door
The format for one of the images caused the build to crash. Attempt to fix it.
The crash seems to be related to the images placed side-by-side, but I'm not entirely sure. Hopefully this fixes it.
I combined the two separate images, so hopefully npm doesn't get upset and crash this time.
I'm not sure why the last image kept causing a crash. Removing it for now, and maybe someone can help me add it back later.
npm crashed even without the image, so that was not the problem. Trying to rewrite the bottom of the file in case there was a hidden character causing the crash.
Seeing if npm crashes without the last step written.
I'm not sure what's causing the npm crash. I'm just going to leave the file so it looks how I intended in the preview, and hopefully someone can help me fix the npm crash.
|
The documentation page looks good in the preview, but when I try to commit it, the npm build crashes. I'm not sure what is causing the crash, and don't want to keep making tiny changes just guessing at what could be the problem. |
|
Came back after sleeping on it, and I was able to understand the problem. I just needed to close the img elements with "/>". |
seleb
approved these changes
Mar 1, 2024
le-doux
approved these changes
Apr 26, 2024
|
this is a great addition to the docs - thank you @vaasut! |
le-doux
added a commit
that referenced
this pull request
May 3, 2024
* Add regenerate button for blips (#236) * Regenerate blips without creating a new one * Regenerating a blip does not modify its name * Write Guide for lockedDoor.md (#257) * Write Guide for lockedDoor.md Write step by step guide with images explaining how to create a locked door * Fix build crash for lockedDoor.md The format for one of the images caused the build to crash. Attempt to fix it. * Fix another build crash in lockedDoor.md The crash seems to be related to the images placed side-by-side, but I'm not entirely sure. Hopefully this fixes it. * Add new image in lockedDoor.md I combined the two separate images, so hopefully npm doesn't get upset and crash this time. * Remove image in lockedDoor.md I'm not sure why the last image kept causing a crash. Removing it for now, and maybe someone can help me add it back later. * Add image back to lockedDoor.md npm crashed even without the image, so that was not the problem. Trying to rewrite the bottom of the file in case there was a hidden character causing the crash. * Removing Step 5 in lockedDoor.md Seeing if npm crashes without the last step written. * Update lockedDoor.md I'm not sure what's causing the npm crash. I'm just going to leave the file so it looks how I intended in the preview, and hopefully someone can help me fix the npm crash. * Add closing tags to img in lockedDoor.md * v8.12 updates --------- Co-authored-by: Alex Nash <[email protected]> Co-authored-by: vaasut <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write step by step guide with images explaining how to create a locked door
Description
The locked door FAQ section was a stub. Wrote a guide with images explaining how to create a locked door.