Skip to content

utils: simplify unpack_extension #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcoratger merged 1 commit into from
Aug 25, 2025
Merged

utils: simplify unpack_extension #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions crates/utils/src/wrappers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
use p3_challenger::DuplexChallenger;
use p3_field::{
BasedVectorSpace, ExtensionField, Field, PackedFieldExtension, PackedValue,
PrimeCharacteristicRing, PrimeField64,
ExtensionField, Field, PackedFieldExtension, PackedValue, PrimeCharacteristicRing, PrimeField64,
};
use p3_koala_bear::KoalaBear;
use p3_symmetric::{
Expand Down Expand Up @@ -69,14 +68,7 @@ pub fn pack_extension<EF: ExtensionField<PF<EF>>>(slice: &[EF]) -> Vec<EFPacking
}

pub fn unpack_extension<EF: ExtensionField<PF<EF>>>(vec: &[EFPacking<EF>]) -> Vec<EF> {
vec.iter()
.flat_map(|x| {
let packed_coeffs = x.as_basis_coefficients_slice();
(0..packing_width::<EF>())
.map(|i| EF::from_basis_coefficients_fn(|j| packed_coeffs[j].as_slice()[i]))
.collect::<Vec<_>>()
})
.collect()
EFPacking::<EF>::to_ext_iter(vec.iter().copied()).collect()
}

#[must_use]
Expand Down