Skip to content

Conversation

@adust09
Copy link
Contributor

@adust09 adust09 commented Sep 19, 2025

  • needless_range_loop / needless-range-loop
    Replaced loops that indexed collections with iterator-based patterns (iter_mut() + enumerate() or direct slice fills) to mutate elements without manual indexing.
  • collapsible_if
    Flattened nested if let/if chains into single guard-style if let statements, keeping control flow intact while reducing nesting.
  • needless_borrow
    Removed superfluous references so functions receive owned or already-borrowed values directly.
  • modulo_one
    Avoided computing a remainder by 1. Instead, added explicit branches (e.g., return a constant true vector when density is 1).
  • wrong_self_convention
    Renamed methods from into_* to to_* when they take &self, aligning with naming conventions.
  • extra-unused-type-parameters
    Dropped unused generic parameters and updated all call sites to match the leaner signatures.
  • field-reassign-with-default
    Used struct update syntax (Struct { field, ..Default::default() }) to set fields during construction rather than mutating after a Default init.
  • ptr_arg
    Switched function parameters from &Vec<> to the more general &[], avoiding unnecessary allocations.
  • cast_lossless
    Replaced as f64 casts with f64::from(...) to prevent potential silent loss and satisfy lint expectations.
  • default_trait_access
    Called typed ::default() constructors (e.g., BTreeMap::default()) instead of Default::default() for clarity.

… for improved clarity and safety. Update point checks to use is_empty() for better readability in multilinear_eval_constants_at_right function. Enhance test cases for polynomial evaluation.
…verify and sumcheck modules to suppress warnings about argument count.
…rove clarity. Update column scalar handling in verification and structured column functions for better performance and readability.
…nce. Update variable handling in array access and assignment logic, and streamline memory access methods.
…erformance. Update argument handling in get_base_dims function to suppress clippy warnings. Simplify dot product index assignments in prove and verify execution functions.
…y functions for improved readability. Replace loop-based assignments with array fill methods to enhance performance.
…cked_pcs, and xmss_aggregate modules for improved readability and performance. Update argument handling and simplify data structures to enhance clarity. Add clippy annotations to suppress warnings.
…ability. Simplify evaluation logic by removing unnecessary line breaks in transmute calls.
@adust09 adust09 closed this Sep 19, 2025
@adust09 adust09 deleted the fix/clippy_error branch December 12, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant