Add Criterion Benchmarks #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks; refactor rec_aggregation module to expose recursion and xmss_aggregate. Introduce examples module in the library and adjust main.rs to use updated paths.
This commit introduces a new benchmark for the Poseidon2 algorithm, utilizing the Criterion library for performance measurement. The benchmark is configured with specific parameters for logging and security assumptions, and it measures the prover time of the Poseidon2 configuration. The new file is located in `benches/poseidon2.rs`.
This commit introduces a new benchmark for the recursion functionality in the `rec_aggregation` module, utilizing the Criterion library for performance measurement. The benchmark is configured with specific parameters for sample size, measurement time, and warm-up time, and it measures the proving time of the recursion implementation. The new benchmark file is located in `benches/recursion.rs`, and the recursion logic has been refactored to support this benchmarking. Additionally, constants have been introduced for better readability and maintainability.
This commit introduces a new benchmark for the XMSS algorithm in the `benches/xmss.rs` file, utilizing the Criterion library for performance measurement. The benchmark is configured with specific parameters for sample size, measurement time, and warm-up time, and it measures the proving time of the XMSS implementation. Additionally, the `xmss_aggregate.rs` file has been refactored to include a new `XmssBenchStats` struct for better organization of benchmarking results and to streamline the benchmarking process. The test function for XMSS aggregation has also been updated to utilize the new benchmarking structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Measure key benchmark metrics with minimal changes to the current implementation
Tests:
cargo benchCurrently, Criterion only records the execution time per iteration for each benchmark function. such as proof size and verification time is not included in Criterion.
Let me know if we need any items.