-
Notifications
You must be signed in to change notification settings - Fork 10
chore: add back tests with poseidon #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
090a200
dee2803
ee1a6c4
11337fe
8e992b7
335e8ec
269d088
861fdfd
419b628
cad926f
f5dbf6c
88cbde3
cec71aa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -587,7 +587,10 @@ mod tests { | |||||
| inc_encoding::target_sum::TargetSumEncoding, | ||||||
| signature::test_templates::test_signature_scheme_correctness, | ||||||
| symmetric::{ | ||||||
| message_hash::{MessageHash, poseidon::PoseidonMessageHashW1}, | ||||||
| message_hash::{ | ||||||
| MessageHash, | ||||||
| poseidon::{PoseidonMessageHash, PoseidonMessageHashW1}, | ||||||
| }, | ||||||
| prf::shake_to_field::ShakePRFtoF, | ||||||
| tweak_hash::poseidon::PoseidonTweakW1L5, | ||||||
| }, | ||||||
|
|
@@ -704,6 +707,40 @@ mod tests { | |||||
| test_signature_scheme_correctness::<Sig>(19, 0, Sig::LIFETIME as usize); | ||||||
| }*/ | ||||||
|
|
||||||
| #[test] | ||||||
| pub fn test_large_base_poseidon() { | ||||||
| // Note: do not use these parameters, they are just for testing | ||||||
| type PRF = ShakePRFtoF<4, 4>; | ||||||
|
||||||
| type PRF = ShakePRFtoF<4, 4>; | |
| type PRF = ShakePRFtoF<24, 8>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood , will revert them back
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we can't have
| const TARGET_SUM: usize = 8 * (256 - 1) / 2; | |
| const TARGET_SUM: usize = 1 << 12; |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we use this?
| const LOG_LIFETIME: usize = 6; | |
| const LOG_LIFETIME: usize = 10; |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we use this as before?
| const LOG_LIFETIME: usize = 6; | |
| const LOG_LIFETIME: usize = 10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the old commented tests