[Experimental - Do not merge] Lean-VM friendly Tweaks #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-wagn
reviewed
Dec 12, 2025
Contributor
b-wagn
left a comment
b-wagn
left a comment
There was a problem hiding this comment.
Seems reasonable to me.
One thing we should probably do though:
I would then make the message hash tweaks have the same structure, namely have it of length three and put the domain separator in the 8 least significant bits of the third field element (right now, it is just two field elements there as well, see here). In this way, it will be more clear that there are no collisions.
Comment on lines
+42
to
+45
| const _: () = assert!( | ||
| F::ORDER_U64 > 1 << 30, | ||
| "we need to store 30 bits in one field element" | ||
| ); |
Contributor
There was a problem hiding this comment.
Nit: throughout the codebase, such checks are usually done in internal_consistency_check()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.