prf: remove small statistical bias in PRF output and speedup #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10
We are switching to 128 bits and made an optimization by not relying on big integers but for now we keep the issue opened since we need more investigations to know if we will switch to 256 bits or not.
Benchmarks after this PR are:
Even if we base from 64 bits to 128, it seems better because we don't rely anymore on big integers which are heavy due to vector allocations and heavy operations, so this is a good news that we increase security while improving performances.