refactor(aggregation): spell out LOG_INVERSE_RATE - #1138
Merged
tcoratger merged 1 commit intoJun 17, 2026
Conversation
Rename the LOG_INV_RATE module constant to LOG_INVERSE_RATE to comply with the no-abbreviations rule. The constant is locally defined and passed positionally to the Rust prover, so this is a pure Python identifier rename with no wire impact. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rename the module constant
LOG_INV_RATEtoLOG_INVERSE_RATEin the lstar aggregation containers.Why
The
INVfragment abbreviates "inverse", violating the no-abbreviations rule for identifiers. A reference spec must spell words out in full.The constant is locally defined (
LOG_INVERSE_RATE: int = 1 if LEAN_ENV == "test" else 2), not imported fromlean_multisig_py, and is passed positionally to the Rust prover functions. Renaming the Python identifier therefore has no effect on the external library contract or any wire format. Pure rename, four occurrences, no behavior change.just checkpasses (lint, format, type check, spell check, mdformat).🤖 Generated with Claude Code