fix(vulture): track the hash_tree_root handler rename - #1150
Merged
tcoratger merged 1 commit intoJun 17, 2026
Conversation
The single-dispatch hash_tree_root handlers were renamed from the _htr_ prefix to the spelled-out _hash_tree_root_ prefix, but the whitelist kept the old names. With the old names no longer defined, vulture reports the renamed handlers as unused and the dead-code check fails. Update the whitelist entries to the current names.
tcoratger
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dead-code CI job (
just deadcode) fails onmain:(see https://github.com/leanEthereum/leanSpec/actions/runs/27710866929/job/81971271367)
Cause
The single-dispatch
hash_tree_roothandlers are registered via@hash_tree_root.register, so their names have no direct call site and vulture cannot see the use. They were whitelisted under the_htr_prefix.A later refactor (#1124) renamed them to the spelled-out
_hash_tree_root_prefix but did not updatevulture_whitelist.py. The old names no longer exist, so the whitelist entries match nothing and the renamed handlers are reported as unused.Fix
Rename the eight whitelist entries to match the current handler names. No source code changes.
Verification
just deadcodefails with the 8 reports above.just deadcodepasses.