refactor(testing): share one workspace-root helper across the CLIs - #1158
Merged
tcoratger merged 1 commit intoJun 18, 2026
Merged
Conversation
The identical workspace-root walk was copy-pasted in fill and apitest. Extract find_workspace_root into the cli package init and call it from both. CLI behavior unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The identical 7-line walk to locate the uv workspace root was copy-pasted byte-for-byte in
cli/fill.pyandcli/apitest.pyand would drift. Extractedfind_workspace_root()intocli/__init__.py(the natural shared home) and call it from both.Behavior identical (returns the first ancestor whose pyproject declares the uv workspace, else cwd). CLI-only, no emitted vectors. Found in the packages/testing audit (INFRA-01).
Lint:
ruff check+ruff formatclean.