test framework: close download tempfile before extracting tarball - #745
Merged
unnawut merged 1 commit intoMay 21, 2026
Merged
Conversation
The previous flow held the temp file open while tarfile reopened the same path with a separate file descriptor. Any tail still in Python's userspace BufferedWriter was invisible to the reader, surfacing as a near-end gzip EOFError that looked like a truncated download. Reproduces deterministically on Python 3.14.5 against the current 152 MB prod_scheme.tar.gz; ~24 KB of the gzip trailer was stranded in the buffer. Restructure download_keys to reserve the temp path, write through a dedicated open()/close() context, then open the closed file for extraction.
Collaborator
Author
|
Merging without approval since this has low side effect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Prod key extraction on latest main branch is failing because the previous flow held the temp file open while tarfile reopened the same path with a separate file descriptor. So there's chance that the tar file content was not fully written before it's being decompressed.
The new code closes the temp-file write context before opening it again for reading, so the kernel sees the full tarball on disk.