refactor(types): drop unused Checkpoint.__lt__ - #754
Merged
Conversation
The dunder had no production caller; advance_to compares slots directly through Slot's comparator rather than ordering Checkpoint against Checkpoint. Without the dunder, max and min over Checkpoint also stop making sense, so the two max-based tests retire along with the six dunder-targeted tests. The four advance_to tests stay. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checkpoint.__lt__had no production caller. The forward-progress helperadvance_tocompares slots directly throughSlot's comparator (candidate.slot > self.slot) — never orderingCheckpointagainstCheckpoint.src/lean_spec/types/checkpoint.py(−8):__lt__deleted.tests/lean_spec/subspecs/containers/test_checkpoint.py(−63 / +2):__lt__tests retired (only exercised the deleted dunder).max(low, high)tests retired (only worked because__lt__was defined;max/minonCheckpointstop making sense without the comparator).advance_totests kept.pytestimport dropped.Test plan
ruff check src/lean_spec/types/checkpoint.py tests/lean_spec/subspecs/containers/test_checkpoint.py— clean.grepacrosssrc/,tests/,packages/— no remaining references toCheckpoint.__lt__or to orderingCheckpointinstances against each other.🤖 Generated with Claude Code