refactor(testing): hoist codec dispatch tables out of run() - #911
Merged
tcoratger merged 1 commit intoJun 10, 2026
Merged
Conversation
Two codec fixtures rebuilt a constant lookup table on every call. The peer-identifier fixture rebuilt a string-to-enum map each run, even though the literal key-type values already match the enum member names. Look the member up directly by name instead, dropping the map. The decode-failure fixture rebuilt its decoder table each call. Hoist it to a module-level constant so it is built once. Both fixtures emit byte-identical vectors: the enum lookup yields the same members as the map, and the decoder table holds the same callables. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Two networking-codec fixtures rebuilt a constant lookup table on every
run()/attempt_decode()call:PeerIdentifierDerivationrebuilt a{str: KeyType}map each call — doubly redundant, since thekey_typeliteral values already match theKeyTypeenum member names once upper-cased.DecodeFailurerebuilt its{str: decoder}table each call.What this does
KeyType[self.key_type.upper()]looks the member up by name ("ed25519"→KeyType.ED25519, etc.).Finalconstant (_DECODERS_BY_NAME), built once at import.Byte-equivalence
The
KeyTypeenum lookup yields the same members as the old map, and the decoder table holds the same callables. Verified by filling the networking suite before and after:Testing
just checkpasses (lint, format, ty, codespell, mdformat).tests/consensus/lstar/networkingvectors are byte-identical to the pre-change output.🤖 Generated with Claude Code