refactor(testing): use A | B syntax in discriminated unions - #912
Merged
tcoratger merged 2 commits intoJun 10, 2026
Merged
Conversation
Three discriminated unions still used typing.Union inside Annotated, while the rest of the package uses the PEP 604 A | B | C syntax. Switch them to A | B | C and drop the now-unused Union import. Pydantic treats Annotated[A | B, Field(discriminator=...)] identically, so every emitted vector is byte-identical. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…criminated-unions # Conflicts: # packages/testing/src/consensus_testing/test_fixtures/networking_codec.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Three discriminated unions still used
typing.UnioninsideAnnotated, while the rest of the package uses the PEP 604A | B | Csyntax (e.g.SlotClockOutput = IntervalOutput | SlotOutput | TotalIntervalsOutput). A small consistency gap.test_types/step_types.py—ForkChoiceStep,FilledForkChoiceSteptest_fixtures/slot_clock.py—SlotClockOperationtest_fixtures/networking_codec.py—NetworkingCodecWhat this does
Switches all three to
Annotated[A | B | C, Field(discriminator=...)]and drops the now-unusedUnionimport from each file. Pydantic v2 treatsAnnotated[A | B, Field(discriminator=...)]identically to theUnionform.Byte-equivalence
Filled the affected suites (fork_choice, networking, slot clock) before and after:
Testing
just checkpasses (lint, format, ty, codespell, mdformat); noUnion[remains in the package.🤖 Generated with Claude Code