Skip to content

refactor(testing): drop duplicate abstract fork name declaration #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcoratger merged 3 commits into from
Jun 10, 2026
Merged

refactor(testing): drop duplicate abstract fork name declaration #913

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bfd8bd
refactor(testing): use A | B syntax in discriminated unions
tcoratger Jun 10, 2026
2a30b0d
refactor(testing): drop duplicate abstract fork name declaration
tcoratger Jun 10, 2026
65e3e2b
Merge remote-tracking branch 'upstream/main' into refactor/dedupe-for…
tcoratger Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions packages/testing/src/consensus_testing/forks/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,11 @@ class BaseForkMeta(ABCMeta):
For example, if ForkB inherits from ForkA, then ForkA precedes ForkB.
"""

@abstractmethod
def name(cls) -> str:
"""Return the name of the fork."""
pass

def __repr__(cls) -> str:
def __repr__(cls: "type[BaseFork]") -> str:
"""Print the name of the fork, instead of the class."""
return cls.name()

def __le__(cls, other: "BaseForkMeta") -> bool:
def __le__(cls: "type[BaseFork]", other: "type[BaseFork]") -> bool:
"""Check if this fork is older or equal to another (cls <= other)."""
return cls is other or issubclass(other, cls)

Expand Down
Loading