Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lints from Dart 3.7 #439

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add lints from Dart 3.7 #439

wants to merge 1 commit into from

Conversation

mchudy
Copy link
Member

@mchudy mchudy commented Feb 23, 2025

No description provided.

@mchudy mchudy added the p: leancode_lint Related to the leancode_lint package label Feb 23, 2025
@mchudy mchudy requested a review from shilangyu as a code owner February 23, 2025 20:32
@@ -365,7 +368,7 @@ linter:
provide_deprecation_message: true
public_member_api_docs: false
recursive_getters: true
require_trailing_commas: true
require_trailing_commas: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling this might not be necessary, since the lint itself will detect the language version — dart-lang/sdk@2227249

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but this fix will land in 3.8.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a TODO in that case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: leancode_lint Related to the leancode_lint package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants