-
Notifications
You must be signed in to change notification settings - Fork 941
chore: golf using grind. add grind annotations.
#32639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
PR summary 790901a8c9Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
grindgrind. add grind annotations.
|
!bench |
|
Benchmark results for 9cb9eeb against 790901a are in! @euprunin No significant changes detected. |
vihdzp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All new grind annotations seem quite reasonable, and all the golfs are quite substantial. Thank you!
Trace profiling results (shown if ≥10 ms before or after):
Finset.filter_product_card: 39 ms before, 114 ms afterFinset.sym2_eq_image: 13 ms before, 67 ms afterList.sublist_iff_exists_fin_orderEmbedding_get_eq: 125 ms before, 148 ms afterEquiv.Perm.isThreeCycle_swap_mul_swap_same: 51 ms before, 79 ms afterPolynomial.gaussNorm_monomial: 12 ms before, 12 ms after 🎉This golfing PR is batched under the following guidelines: