Skip to content

Conversation

@euprunin
Copy link
Collaborator

@euprunin euprunin commented Dec 9, 2025


Trace profiling results (shown if ≥10 ms before or after):

  • Finset.filter_product_card: 39 ms before, 114 ms after
  • Finset.sym2_eq_image: 13 ms before, 67 ms after
  • List.sublist_iff_exists_fin_orderEmbedding_get_eq: 125 ms before, 148 ms after
  • Equiv.Perm.isThreeCycle_swap_mul_swap_same: 51 ms before, 79 ms after
  • Polynomial.gaussNorm_monomial: 12 ms before, 12 ms after 🎉

This golfing PR is batched under the following guidelines:

  • Up to ~5 changed files per PR
  • Up to ~25 changed declarations per PR
  • Up to ~100 changed lines per PR

Open in Gitpod

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

PR summary 790901a8c9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@bryangingechen bryangingechen added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 10, 2025
@euprunin euprunin removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 10, 2025
@euprunin euprunin changed the title chore: golf using grind chore: golf using grind. add grind annotations. Dec 10, 2025
@euprunin
Copy link
Collaborator Author

!bench

@leanprover-radar
Copy link

leanprover-radar commented Dec 10, 2025

Benchmark results for 9cb9eeb against 790901a are in! @euprunin

No significant changes detected.

Copy link
Collaborator

@vihdzp vihdzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All new grind annotations seem quite reasonable, and all the golfs are quite substantial. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants