Skip to content

Conversation

@harahu
Copy link
Contributor

@harahu harahu commented Dec 9, 2025

Typos found and fixed by Codex.


I'd like feedback on whether this size of typo PR is fine to review, or whether it should be split up further.

Open in Gitpod

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

PR summary 6626d3a1ec

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Dec 9, 2025
Copy link
Contributor

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In my opinion, the size of PR is fine, provided the changes are all this trivial.
bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 10, 2025
@bryangingechen
Copy link
Contributor

bors r-
bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 10, 2025

✌️ harahu can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 10, 2025

Canceled.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed ready-to-merge This PR has been sent to bors. delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). labels Dec 10, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 10, 2025
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 10, 2025
@harahu
Copy link
Contributor Author

harahu commented Dec 10, 2025

bors r+

@harahu
Copy link
Contributor Author

harahu commented Dec 10, 2025

@bryangingechen It seems that your delegation was wiped by bors. This looks like a logic error in bors?

Anyway, do you mind merging this? I addressed the merge conflict.

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 11, 2025
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@harahu harahu force-pushed the doc/topology-typos branch from 4b86bfd to 2109d3d Compare December 11, 2025 12:34
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 11, 2025
@harahu harahu force-pushed the doc/topology-typos branch from 2109d3d to cf977ae Compare December 11, 2025 12:40
@bryangingechen
Copy link
Contributor

bryangingechen commented Dec 11, 2025

I checked bors and it looks like the delegation wasn't removed. It looks like your comment has a space in front of bors r+ which caused it to be ignored. (This is the second time that I've seen someone caught by this so I'll update bors to strip leading whitespace before parsing comments when I have a chance. The downside is that bors will react to people using indentation to put bors commands in code blocks, but I think that is much rarer.)

There seem to be some github issues, so I'm not sure if this will go through, you may have to run bors r+ again later.

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 11, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 11, 2025
Typos found and fixed by Codex.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 11, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title doc(Topology): fix typos [Merged by Bors] - doc(Topology): fix typos Dec 11, 2025
@mathlib-bors mathlib-bors bot closed this Dec 11, 2025
@harahu harahu deleted the doc/topology-typos branch December 11, 2025 19:03
@harahu
Copy link
Contributor Author

harahu commented Dec 11, 2025

Thank you, both for the feedback, and for looking into the issue I had with bors. I think I assumed the delegation was removed because the "delegated" label here in github was removed by the leanprover-community-mathlib4-bot. But it makes sense that there isn't necessarily a 1-1 correspondence between the labels and the actual state.

Can't promise I had figured it out even if the label was still in place, though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants