-
Notifications
You must be signed in to change notification settings - Fork 934
[Merged by Bors] - doc(Topology): fix typos #32659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR summary 6626d3a1ecImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
bryangingechen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! In my opinion, the size of PR is fine, provided the changes are all this trivial.
bors r+
|
bors r- |
|
✌️ harahu can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Canceled. |
|
This pull request has conflicts, please merge |
|
bors r+ |
|
@bryangingechen It seems that your delegation was wiped by bors. This looks like a logic error in bors? Anyway, do you mind merging this? I addressed the merge conflict. |
|
This pull request has conflicts, please merge |
4b86bfd to
2109d3d
Compare
2109d3d to
cf977ae
Compare
|
I checked bors and it looks like the delegation wasn't removed. It looks like your comment has a space in front of There seem to be some github issues, so I'm not sure if this will go through, you may have to run bors r+ |
Typos found and fixed by Codex.
|
Pull request successfully merged into master. Build succeeded: |
|
Thank you, both for the feedback, and for looking into the issue I had with bors. I think I assumed the delegation was removed because the "delegated" label here in github was removed by the leanprover-community-mathlib4-bot. But it makes sense that there isn't necessarily a 1-1 correspondence between the labels and the actual state. Can't promise I had figured it out even if the label was still in place, though... |
Typos found and fixed by Codex.
I'd like feedback on whether this size of typo PR is fine to review, or whether it should be split up further.