fix: don't fetch unused cache, FF fixes #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the result of
fetchCachedDeclarationDatawas ignored due to #133, we were still performing the request, which takes some time on FF to deserialize (or something), depending on what happened to be on the user's cache (because the cache is never written to, only read). This moves the disabling earlier, so that the cache is not read at all (since this means deserializing an old version of the mathlib JSON data, then ignoring it and fetching another version of the mathlib JSON data).Also fixes an issue where the
undefinedpattern is passed todecodeURIComponent(resulting in"undefined"which is mishandled by subsequent code).