Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve build issues with mathlib #243

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

eric-wieser
Copy link
Contributor

See https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/lean4checker.20failure/near/486823143 for more details.

If initializers don't run, then the parsers registered with initlialize add_parser_alias .. do not run, and so the alias never exists and the downstream code that references the alias crashes.

import-graph and the Batteries linter framework already include this line.

I have not tested if this actually resolves the mathlib build issue,

See https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/lean4checker.20failure/near/486823143 for more details.

If initializers don't run, then the parsers registered with `initlialize add_parser_alias ..` do not run, and so the alias never exists and the downstream code that references the alias crashes.

`import-graph` and the Batteries linter framework already include this line.
@hargoniX hargoniX merged commit 82c0223 into leanprover:main Dec 9, 2024
1 check passed
YaelDillies added a commit to YaelDillies/LeanCamCombi that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants