feat: add BitVec.getLsbD_false_of_clz
#11349
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds `BitVec.getLsbD_false_of_clz`, which states that the boolean value of any bit in the 'leading zero bits' of a BitVec is false. `BitVec.getLsbD_false_of_clzAuxRec` does already exist, but `BitVec.clzAuxRec` is really just an implementation detail of `BitVec.clz`, and it is more useful to have lemmas which directly state properties of `BitVec.clz`, rather than the auxiliary function which it uses internally.
Author
|
First PR here, I've tried to read through the material in |
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
BitVec.getLsbD_false_of_clz, which states that the boolean value of any bit in the 'leading zero bits' of a BitVec is false.BitVec.getLsbD_false_of_clzAuxRecdoes already exist, butBitVec.clzAuxRecis really just an implementation detail ofBitVec.clz, and it is more useful to have lemmas which directly state properties ofBitVec.clz, rather than the auxiliary function which it uses internally.