Skip to content

feat: update mkCoe, ensureHasType, and elabTermEnsuringType to allow MessageData headers #11390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: update mkCoe, ensureHasType, and elabTermEnsuringType to allow MessageData headers #11390

wants to merge 2 commits into from

Conversation

@thorimur
Copy link
Contributor

@thorimur thorimur commented Nov 26, 2025 •
edited
Loading

This PR updates mkCoe, ensureHasType, and elabTermEnsuringType to allow optional MessageData headers instead of optional String headers.

thorimur
thorimur commented Nov 26, 2025
View reviewed changes
Copy link
Contributor Author

@thorimur thorimur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog-language

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 27, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Nov 27, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-11-25 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-11-27 00:50:59)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 27, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11390
e55566e
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Nov 27, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11390
8fae601
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 27, 2025

Mathlib CI status (docs):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thorimur @leanprover-bot @leanprover-community-bot