Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a recursor application is stuck if the major contains metavariables #4592

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: a recursor application is stuck if the major contains metavariables #4592

wants to merge 2 commits into from

Conversation

JovanGerb
Copy link
Contributor

Discrimination tree lookup throws an isDefEqStuckEx for any recursor application with metavariables. However, this should only be if there are metavariables in the major. I copied the same changes from DiscrTree to LazyDiscrTree.

This came up in a Zulip conversation. In particular, the isDefEqStuck exception happened in tryUnificationHints during isDefEq, which does a DiscrTree lookup.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 30, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 30, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4592
479abb3
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 30, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4592
b9d292a
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jun 30, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Jun 30, 2024 •
edited
Loading

Mathlib CI status (docs):

@JovanGerb JovanGerb mentioned this pull request Jul 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JovanGerb @leanprover-community-mathlib4-bot