Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better bundling #3

Merged
merged 9 commits into from
May 21, 2019
Merged

Better bundling #3

merged 9 commits into from
May 21, 2019

Conversation

sunify
Copy link
Member

@sunify sunify commented May 20, 2019

No description provided.

@sunify sunify marked this pull request as ready for review May 21, 2019 07:05
@TimDaub
Copy link

TimDaub commented May 21, 2019

Conflicting files
build/index.js

  1. You commented out the ENS integration. I completely removed it from the burner-wallet here. It wasn't consistently implemented. I think it's safe to remove it. We can add it at a later point in time again in my opinion.

TimDaub
TimDaub approved these changes May 21, 2019
View reviewed changes
Copy link

@TimDaub TimDaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunify sunify merged commit 66912e7 into pdai-more-changes May 21, 2019
@sunify sunify deleted the better-bundling branch May 21, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimDaub TimDaub TimDaub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunify @TimDaub