Fix/send eth button in Exchange #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimDaub
force-pushed
the
fix/send-eth-button
branch
from
ba1e095
to
f745e12
Compare
TimDaub
force-pushed
the
fix/send-eth-button
branch
from
f745e12
to
d5c647c
Compare
johannbarbie
approved these changes
Jun 7, 2019
johannbarbie
reviewed
Jun 7, 2019
| let paramsObject = { | ||
| from: daiAddress, | ||
| value: actualEthSendAmount, | ||
| gas: 240000, |
There was a problem hiding this comment.
why such high estimate? the tx only used 21,000 here: https://rinkeby.etherscan.io/tx/0x31c2ce3039741ea64e23adc72af89428c8f3f334159350b1807ff9c8b8d0d6b2
There was a problem hiding this comment.
It's legacy stuff. GasLimits are set arbitrarily like that everywhere. We should actually use .estimateGas everywhere.
I'd proceed by leaving it for now and opening an issue upstream. OK?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126
TODOs: