Stanford template override stuff #2607

willgearty · 2018-08-24T05:48:28Z

This is a work in progress of integrating lots of Stanford template override changes into main, since a number of them are useful for other sites. Some of these are fixes, some are additions, and some might not even be useful, but I tried to include whatever I thought my be good for main. I've still got a couple big template overrides, but this covers all of the smaller things.

~~teachereventsmodule/event_signup.html~~ (implemented in Teacher event signup layout redesign #2709)
profiles/...
users/student_schedule.html
users/teacherbio.html
users/userview_class_entry.html
~~users/loginbox_content.html~~ (part of theme)
~~teacherclassregmodule/classedit.html~~ (highly customized)
~~teacherclassregmodule/listclasses.html~~ (highly customized)
~~volunteersignup/signup.html~~ (changes are being implemented in Make all availability pages look and act the same #2583)

benjaminjkraft · 2018-08-25T00:18:32Z

A lot of these look good; I'll take a closer look later. To aid in reviewing, it might be helpful to post screenshots of some of these changes -- especially the CSS where the effect may be less obvious -- with another theme(s) enabled.

willgearty · 2018-08-26T03:03:03Z

Here is a screenshot of the changes to the teacher events manage page:

willgearty · 2018-08-26T04:21:12Z

Here's what the student schedule now looks like:

willgearty · 2018-08-26T04:59:13Z

Here's what the "Classes Taught" section of userview looks like:

willgearty · 2018-08-26T05:08:40Z

The float: none additions may only be applicable to the Stanford theme, since part of our theme wants to push some of those buttons to the right via float: right, but I figured it would be good to just make sure they aren't getting moved in other themes.
Another thing I noticed (e.g. on the teacherbio page), is that the circles theme uses a blue color for visited links, so any time an <a> tag is used with the btn-primary class, it's hard to see the text in the button.

Otherwise, happy to provide examples of anything else!

benjaminjkraft

Cool! Lots of good stuff in here. There are enough questions that we probably need another round, but feel free to bug me about this one, since it touches enough things that it will bitrot pretty fast (there's already a merge conflict).

esp/templates/program/modules/adminclass/manageclass.html

esp/templates/program/modules/adminclass/manageclass_class_info.html

esp/templates/program/modules/studentregphasezero/status.html

esp/templates/program/modules/studentregphasezero/submit.html

esp/templates/program/modules/teacherclassregmodule/coteachers.html

esp/templates/program/modules/teachereventsmodule/event_signup.html

esp/templates/users/profile.html

esp/templates/users/student_schedule.html

esp/templates/users/teacherbio.html

willgearty · 2019-03-23T20:22:40Z

This should be good for a final review @benjaminjkraft !

kkbrum · 2019-04-17T04:46:14Z

esp/templates/users/userview.html

@@ -30,6 +30,9 @@ <h1>User Information</h1>
            {% endfor %}
        </select>
    </form>
+    {% if profile.teacher_info %}


This doesn't catch my account, which is a teacher & student & admin. It catches people who are just teachers, but if we want to include this we should probably make it catch the case of teacher being just one of the roles?

(same with line 97 though)

Hmm...this is probably a broader issue related to how profiles and contact infos work, but I should be able to fix this by just doing something like {% if "Teacher" in user.getUserTypes %}.

(And do the same for all the other user type conditionals)

kkbrum

I added one comment on part of the code that could be improved, but it's not really an issue due to your template changes or anything-- just something I noticed that existed before as well.

Everything looks good to go for me! I only checked on bigpicture theme though and didn't look at survey or lottery things since I have never really used them. Let me know if you'd like me to check anything more carefully.

* Placeholders for SR11 release notes * Included guardian AUL info * Added credit card charge name and login fixes * Add miscellaneous fixes, list PRs for major improvements * formatting tweaks * change heading * list of known issues * Known issues documentation * class search docs * Userview docs * resource docs * onsite docs * QSD/comm panel docs * Typos * Convert to code * More code * Documentation for #2702 * Docs for #2698 and #2703 * Added known issue from #2670 * Update duration documentation * Docs for #2711 and #2712, new category * Email and scheduling assistant docs * Docs for #2681 * Add doc for issue 2701 * Fix link * Doc for #2695 * Docs for #2641 * Docs for #2607 * Docs for #2714. * Docs for #2719 and #2723 * Add AUL documentation for teacher grad year/school * add english-fixes changes * Fix language docs * Docs for #2622 * Docs for #2739 * Docs for #2724, #2740, and #2742 * Docs for #2743, #2747, #2749, and #2750 * Created more sections to make it easier to skim * Standardized capitalization * Update known issues to match sr11 bug fixes milestone * Final edits before SR11 * Update release date

* First pass of Stanford template overrides * teacherbio changes * userview_class_entry changes * student_schedule changes * https fix * event_signup changes * profiles changes * some things don't transfer to other themes * manageclass tweaks * Revert teacher event signup * Changes for review

* Placeholders for SR11 release notes * Included guardian AUL info * Added credit card charge name and login fixes * Add miscellaneous fixes, list PRs for major improvements * formatting tweaks * change heading * list of known issues * Known issues documentation * class search docs * Userview docs * resource docs * onsite docs * QSD/comm panel docs * Typos * Convert to code * More code * Documentation for #2702 * Docs for #2698 and #2703 * Added known issue from #2670 * Update duration documentation * Docs for #2711 and #2712, new category * Email and scheduling assistant docs * Docs for #2681 * Add doc for issue 2701 * Fix link * Doc for #2695 * Docs for #2641 * Docs for #2607 * Docs for #2714. * Docs for #2719 and #2723 * Add AUL documentation for teacher grad year/school * add english-fixes changes * Fix language docs * Docs for #2622 * Docs for #2739 * Docs for #2724, #2740, and #2742 * Docs for #2743, #2747, #2749, and #2750 * Created more sections to make it easier to skim * Standardized capitalization * Update known issues to match sr11 bug fixes milestone * Final edits before SR11 * Update release date

First pass of Stanford template overrides

6e38e1a

willgearty added the Work in progress label Aug 24, 2018

willgearty added 3 commits August 24, 2018 08:57

teacherbio changes

60a1387

userview_class_entry changes

0fdb850

student_schedule changes

549b009

willgearty added 2 commits August 24, 2018 15:10

https fix

79e91c7

event_signup changes

4878a5e

willgearty added the UserInterface label Aug 24, 2018

profiles changes

35c1774

willgearty added 2 commits August 25, 2018 20:33

some things don't transfer to other themes

38d448c

manageclass tweaks

522d3c5

willgearty removed the Work in progress label Aug 26, 2018

benjaminjkraft reviewed Sep 5, 2018

View reviewed changes

Merge branch 'main' into stanford-templates

eb0f85c

willgearty added the Work in progress label Mar 13, 2019

willgearty added 3 commits March 22, 2019 10:40

Revert teacher event signup

0e09714

merge conflicts

9d8e75e

Changes for review

0884825

willgearty removed the Work in progress label Mar 23, 2019

willgearty added this to the Stable Release 11 milestone Mar 23, 2019

kkbrum reviewed Apr 17, 2019

View reviewed changes

kkbrum approved these changes Apr 17, 2019

View reviewed changes

willgearty merged commit 09ff26d into main Apr 17, 2019

willgearty deleted the stanford-templates branch April 17, 2019 15:38

willgearty added a commit that referenced this pull request Apr 17, 2019

Docs for #2607

98b11b3

willgearty mentioned this pull request Apr 19, 2019

RegProfileModule doesn't distinguish between teacher and student profiles #2722

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stanford template override stuff #2607

Stanford template override stuff #2607

willgearty commented Aug 24, 2018 •

edited

Loading

benjaminjkraft commented Aug 25, 2018

willgearty commented Aug 26, 2018 •

edited

Loading

willgearty commented Aug 26, 2018

willgearty commented Aug 26, 2018

willgearty commented Aug 26, 2018

benjaminjkraft left a comment

willgearty commented Mar 23, 2019

kkbrum Apr 17, 2019

kkbrum Apr 17, 2019

willgearty Apr 17, 2019 •

edited

Loading

willgearty Apr 17, 2019 •

edited

Loading

kkbrum left a comment

Stanford template override stuff #2607

Stanford template override stuff #2607

Conversation

willgearty commented Aug 24, 2018 • edited Loading

benjaminjkraft commented Aug 25, 2018

willgearty commented Aug 26, 2018 • edited Loading

willgearty commented Aug 26, 2018

willgearty commented Aug 26, 2018

willgearty commented Aug 26, 2018

benjaminjkraft left a comment

Choose a reason for hiding this comment

willgearty commented Mar 23, 2019

kkbrum Apr 17, 2019

Choose a reason for hiding this comment

kkbrum Apr 17, 2019

Choose a reason for hiding this comment

willgearty Apr 17, 2019 • edited Loading

Choose a reason for hiding this comment

willgearty Apr 17, 2019 • edited Loading

Choose a reason for hiding this comment

kkbrum left a comment

Choose a reason for hiding this comment

willgearty commented Aug 24, 2018 •

edited

Loading

willgearty commented Aug 26, 2018 •

edited

Loading

willgearty Apr 17, 2019 •

edited

Loading

willgearty Apr 17, 2019 •

edited

Loading