Fix selenium tests #3460
Open
Fix selenium tests #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging 938fbae into f3f902b - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes our selenium tests (front-end behavior tests) that haven't been running for ages (if not ever). We don't really have a lot of them (and some that were marked as such aren't actually selenium tests), but this opens the avenue to potentially create more in the future. Previously, the selenium tests had to be run separately using a separate management command, but now they are just included in our normal set of unit tests (so they should also be run with Github Actions every time a PR is created). We also have some JS tests for the ajax scheduler, but those are currently written in jasmine and are therefore outside of the scope of this PR.