-
Notifications
You must be signed in to change notification settings - Fork 105
Add v-model support to KCheckbox #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WinnyChang
wants to merge
6
commits into
learningequality:develop
Choose a base branch
from
WinnyChang:kcheckbox-v-model-support
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d10ef25
Add v-model support to KCheckbox and update its documentation page
WinnyChang eaaa215
Update existing unit tests to use VTL and to work with v-model
WinnyChang 606fead
Update existing visual tests to work with v-model
WinnyChang 3a78465
Support both :checked/@change and v-model API, adjust props and event…
WinnyChang 23f6167
Use DocsExample and example files, add :checked/@change examples
WinnyChang 4ccac4d
Update to use the change event for both v-model and legacy API
WinnyChang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,21 @@ | ||
| <template> | ||
|
|
||
| <KCheckbox | ||
| v-model="inputValue" | ||
| label="Deselected checkbox" | ||
| :checked="false" | ||
| /> | ||
|
|
||
| </template> | ||
|
|
||
|
|
||
| <script> | ||
|
|
||
| export default { | ||
| data() { | ||
| return { | ||
| inputValue: false, | ||
| }; | ||
| }, | ||
| }; | ||
|
|
||
| </script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,22 @@ | ||
| <template> | ||
|
|
||
| <KCheckbox | ||
| v-model="inputValue" | ||
| label="Deselected disabled checkbox" | ||
| :checked="false" | ||
| :disabled="true" | ||
| /> | ||
|
|
||
| </template> | ||
|
|
||
|
|
||
| <script> | ||
|
|
||
| export default { | ||
| data() { | ||
| return { | ||
| inputValue: false, | ||
| }; | ||
| }, | ||
| }; | ||
|
|
||
| </script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,22 @@ | ||
| <template> | ||
|
|
||
| <KCheckbox | ||
| v-model="inputValue" | ||
| label="Indeterminate checkbox" | ||
| :indeterminate="true" | ||
| /> | ||
|
|
||
| </template> | ||
|
|
||
|
|
||
| <script> | ||
|
|
||
| export default { | ||
| data() { | ||
| return { | ||
| inputValue: false, | ||
| }; | ||
| }, | ||
| }; | ||
|
|
||
| </script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,23 @@ | ||
| <template> | ||
|
|
||
| <KCheckbox | ||
| v-model="inputValue" | ||
| label="Indeterminate disabled checkbox" | ||
| :indeterminate="true" | ||
| :disabled="true" | ||
| /> | ||
|
|
||
| </template> | ||
|
|
||
|
|
||
| <script> | ||
|
|
||
| export default { | ||
| data() { | ||
| return { | ||
| inputValue: false, | ||
| }; | ||
| }, | ||
| }; | ||
|
|
||
| </script> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.