Use a different glob lib for now#11913
Merged
rtibbles merged 3 commits intolearningequality:release-v0.16.xfrom Feb 23, 2024
Merged
Use a different glob lib for now#11913rtibbles merged 3 commits intolearningequality:release-v0.16.xfrom
rtibbles merged 3 commits intolearningequality:release-v0.16.xfrom
Conversation
Contributor
Build Artifacts
|
rtibbles
approved these changes
Feb 23, 2024
Member
rtibbles
left a comment
There was a problem hiding this comment.
Code changes look good, manual testing of the lint-frontend yarn command checks out, and the compression logic successfully compressed all relevant files from examination of the WHL build logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There are issues with yarn v1 and the node package
glob>=10.0.0 because yarn v1's lack of support for package aliases and yarn's hoisting don't mix wellReferences
The following occurs indeterminately on Studio trying to use the latest
kolibri-tools:because
globrequiresjackspeakand in turn depends upon a forked version of yargscliuithat has dependency onwrap-ansi. The fork uses module aliases which we see here trying to unpackagewrap-ansi-cjsinto an already existingwrap-ansi. Upgrading to a newer version of yarn should fix it but it also nets no improvement as there are still issues to resolve. We should prioritize it though, as well as upgrading kolibri-tools to ESM eventually. As far as the fork, there is an alternative PR open which would solve things without module aliases.Reviewer guidance
yarn lint-frontendutilizes the modified codeTesting checklist
PR process
Reviewer checklist
yarnandpip)