Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional setting to ignore an existing process on resuming a sync #194

Merged

Conversation

bjester
Copy link
Member

@bjester bjester commented Jul 25, 2023

Background

Morango stores the process ID on the sync session to prevent accidental resumption of a sync that is still active in another process. On Kolibri, if a sync was started via the UI but then fails, when a user tries to manually resume the sync outside of Kolibri's UI and task processing, the check that ensures the process ID is either the same or inactive can fail because the worker processing tasks is likely still a running and active process.

Summary

  • Adds ignore_existing_process keyword arg to resume_sync_session allowing the bypass of checking the existing process ID

TODO

  • Have tests been written for the new code?
  • Has documentation been written/updated?
  • New dependencies (if any) added to requirements file

Reviewer guidance

  • The test and code review
  • This work has been merged into this PR, which will run GH action checks against the updates

Issues addressed

Fixes #193

Copy link
Member

@jamalex jamalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! This looks great from my side -- I had one initial reaction wondering how this would actually be used via the CLI, then I remembered that part lives in Kolibri, so I'm assuming the option to tie into this will live there.

@bjester bjester added this to the Kolibri 0.16: Morango milestone Aug 29, 2023
@bjester bjester merged commit 4e51901 into learningequality:release-v0.6.x Sep 28, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants