Add custom user agent #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bjester this is ready to merge sir. |
bjester
force-pushed
the
customised_user_agent
branch
from
0a9133d
to
79d05e9
Compare
bjester
approved these changes
Sep 28, 2023
|
Docs build was fixed in a separate PR |
bjester
merged commit 3eb9b13
into
learningequality:release-v0.6.x
18 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #196
This PR adds a custom user agent that adds information about morango and the product it is integrated with.
For example, with Kolibri 0.16.0, user agent should be:-
User-Agent: morango/0.6.17 kolibri/0.16.0 python-requests/2.28.2TODO
Reviewer guidance
The unit test should be sufficient I feel.
Issues addressed
Closes #191.