Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH action workflows for py2.7 deprecation #199

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

bjester
Copy link
Member

@bjester bjester commented Sep 11, 2023

Summary

  • Updates Morango's python2 linting to be functional
  • Updates workflows to have skip checks in each step, to prevent situations for 'waiting to be queued' checks
  • Fixes other related issues

@bjester bjester marked this pull request as ready for review September 11, 2023 19:42
.github/workflows/tox.yml Outdated Show resolved Hide resolved
@rtibbles
Copy link
Member

Looks like the matrixing worked, but now something is breaking in imports in tests, presumably new things in the stdlib not in py3.4?

@bjester
Copy link
Member Author

bjester commented Sep 12, 2023

Looks like the matrixing worked, but now something is breaking in imports in tests, presumably new things in the stdlib not in py3.4?

Yeah the test.support backport just needed to be installed, which left the more troublesome combination for 3.4 + crypto. The package repositories are no longer live for the most recent python image, as it's beyond LTS. I guess that's reason enough to drop 3.4? with crypto at the least.

@rtibbles
Copy link
Member

Yeah, 3.4 is a massive pain, 3.5 is tricky, and 2.7 zombies on!

@rtibbles rtibbles merged commit 7320330 into learningequality:release-v0.6.x Sep 12, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants