Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ReadTheDocs builds configuration #202

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Update ReadTheDocs builds configuration #202

merged 5 commits into from
Sep 28, 2023

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Sep 15, 2023 •
edited
Loading

Summary

  • Starting on September 25, ReadTheDocs builds without configuration file won't work anymore. This adds the configuration file.
  • Cleans up code around sphinx-rtd-theme configuration

References

https://blog.readthedocs.com/migrate-configuration-v2/

Reviewer guidance

  • Preview the configuration file
  • Preview the production docs build: TODO
  • Preview the local docs build

@MisRob MisRob mentioned this pull request Sep 15, 2023
Closed
@MisRob
Copy link
Member Author

MisRob commented Sep 15, 2023

The production docs build is failing due to some issues with dependencies.

Logs: https://gist.github.com/MisRob/22d6672bc93c5f086e4eba5c8cdd14b1

@bjester
Copy link
Member

bjester commented Sep 21, 2023 •
edited
Loading

Thanks @MisRob! Could you possibly re-target this to the release-v0.6.x branch?

@bjester bjester changed the base branch from release-v0.7.x to release-v0.6.x September 28, 2023 15:44
@bjester
Copy link
Member

bjester commented Sep 28, 2023

Not sure why the postgres test failed-- may be flaky. Merging anyway!

@bjester bjester merged commit 5dcbb40 into learningequality:release-v0.6.x Sep 28, 2023
18 of 19 checks passed
@MisRob
Copy link
Member Author

MisRob commented Sep 28, 2023

Thanks @bjester, apologies I didn't get to this in time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjester bjester bjester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MisRob @bjester