Don't close sync session unless also older than cutoff #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtibbles
approved these changes
Nov 14, 2023
| @@ -97,8 +98,7 @@ def handle(self, *args, **options): | |||
| transfer_count = transfer_sessions.count() | |||
|
|
|||
| # loop over the stale sessions one by one to close them out | |||
| for i in range(transfer_count): | |||
| transfer_session = transfer_sessions[0] | |||
There was a problem hiding this comment.
Oh, so this and below was only ever affecting the first transfer/sync session!
There was a problem hiding this comment.
No I think this was operating as expected. The sync session one though had the problem.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to support sync resumption and automated clean up of incomplete transfers for Kolibri's learn-only device syncing, the command needs to also filter the sync sessions to only those that have been inactive for at least the
expirationamount of timelast_activity_timestampfilter to sync sessions before iterating to clean them upTODO
Reviewer guidance
Do the tests make sense
Issues addressed
Fixes #183
Documentation
If the PR has documentation, link the file here (either .rst in your repo or if built on Read The Docs)