Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Django to 3.2 #217

Merged
merged 11 commits into from
Mar 7, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Mar 5, 2024

Summary

  • Upgrade Django to 3.2
  • Upgrade DRF
  • Remove use of Django six
  • Remove no longer used MorangoMPTT model custom handling
  • Update fields to remove context argument
  • Upgrade MPTT and create new migrations for PositiveIntegerField etc.
  • Use python functools.
  • Don't use schema editor as context (no longer allowed for SQLite)
  • Update Django middleware name.
  • Set now required output field on function.
  • Update how we handle custom serialization and deserialization, following Django's own serialization framework that conditionally renders to string or leaves data types raw - allows specific fields to opt in to string serialization.
  • Importantly, this handling now updates serialization and deserialization behaviour, which it did not previously.
  • Update the syncsession tests to run the additional server in an isolated process, as databases were no longer being properly set in the LiveServerThread for LiveServerTestCase
  • Updates the psycopg2-binary package to the latest compatible version

TODO

  • Have tests been written for the new code?
  • New dependencies (if any) added to requirements file

Issues addressed

Fixes #208

@rtibbles
Copy link
Member Author

rtibbles commented Mar 5, 2024

Oh, whoops, I left a print statement in here too!

@rtibbles rtibbles force-pushed the django_unchained branch 2 times, most recently from b88cf0c to ad0f0aa Compare March 6, 2024 16:55
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and all the tests are happy 👍

@bjester bjester merged commit 64b4790 into learningequality:release-v0.8.x Mar 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Django 3.2
2 participants