Squash migrations to prevent issues with older SQLite versions. #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtibbles
force-pushed
the
old_sqlite_compatible_migrations
branch
2 times, most recently
from
dceba52
to
57a5a11
Compare
Add regression test.
Remove obselete version key.
rtibbles
force-pushed
the
old_sqlite_compatible_migrations
branch
from
57a5a11
to
ac4d5a3
Compare
|
@rtibbles I'm still having trouble with this, for example while testing this PR learningequality/kolibri#12397 - can we please have that change applied to the new builds? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Squashes historic migrations so that we don't trigger SQLite issues with renaming columns within a transaction.
Adds a regression test suite to run migrations against SQLite 3.25.3 - this could be generalized to run against multiple SQLite versions, but I did the minimal implementation for now, as this is the version we have a known issue.
Running the same steps locally prior to the squashed migration, I replicated the reported error, the migration squash fixes it.
Reviewer guidance
I will open a draft PR on Kolibri with this update so we can test that it fixes the issue in Kolibri specifically
Issues addressed
Fixes #224