Skip to content

Commit

Permalink
chore: pr feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
camerow committed Sep 27, 2024
1 parent d49c5ba commit 143a8c5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
8 changes: 3 additions & 5 deletions packages/analytics/src/index.native.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ let analyticsClient: AnalyticsClient<GenericAnalyticsClient>;
* @param {AnalyticsClientConfig} config - The configuration for the analytics client.
* @returns {AnalyticsClient<SegmentClient>} The configured analytics client.
*/
const configureAnalyticsClient = ({
export function configureAnalyticsClient({
writeKey,
defaultProperties,
client,
}: AnalyticsClientConfig) => {
}: AnalyticsClientConfig) {
const nativeClient =
client ??
createClient({
Expand All @@ -24,6 +24,4 @@ const configureAnalyticsClient = ({
analyticsClient = new AnalyticsClient(nativeClient, { defaultProperties });

return analyticsClient;
};

export { analyticsClient, configureAnalyticsClient };
}
8 changes: 4 additions & 4 deletions packages/analytics/src/index.web.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,16 @@ let analyticsClient: AnalyticsClient<GenericAnalyticsClient>;
* @param {AnalyticsClientConfig} config - The configuration for the analytics client.
* @returns {AnalyticsClient<AnalyticsBrowser>} The configured analytics client.
*/
const configureAnalyticsClient = ({
export function configureAnalyticsClient({
client,
writeKey,
defaultProperties,
}: AnalyticsClientConfig) => {
}: AnalyticsClientConfig) {
const webClient = client ?? AnalyticsBrowser.load({ writeKey });

analyticsClient = new AnalyticsClient(webClient, { defaultProperties });

return analyticsClient;
};
}

export { analyticsClient, configureAnalyticsClient };
export { analyticsClient };

0 comments on commit 143a8c5

Please sign in to comment.