-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: collectibles widget #458
Conversation
c8e116a
to
338a9ac
Compare
338a9ac
to
b780ee4
Compare
apps/mobile/src/components/widgets/collectibles/components/collectible-card-layout.tsx
Outdated
Show resolved
Hide resolved
Opening this for review but it has a known type error I need to solve |
9f835b5
to
e87783d
Compare
Fixed |
2d95724
to
4be26d2
Compare
apps/mobile/src/components/widgets/collectibles/components/collectible-text.tsx
Show resolved
Hide resolved
4be26d2
to
f126931
Compare
apps/mobile/src/components/widgets/collectibles/components/collectible-card-layout.tsx
Show resolved
Hide resolved
I wonder what's the reason for it not going all the way to the right: collectibles.movAnd i think we should also add "5" padding to the inside of the scrollview so that it doesn't stick to the end of the phone. You can do it with |
Thanks, let me check. I face the same issue with the scrollview on the I had padding but no margin and it wasn't going the full width of the screen: https://github.com/leather-io/issues/issues/322 |
f126931
to
fbd6c7e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #458 +/- ##
=======================================
Coverage 22.39% 22.39%
=======================================
Files 132 132
Lines 5519 5519
Branches 241 241
=======================================
Hits 1236 1236
Misses 4283 4283
|
I'm going to close this for now and spend more time investigating #458 (comment) and also moving the extension |
This PR adds the collectibles widget using mock data
Area.mp4