Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collectibles widget #458

Closed
wants to merge 1 commit into from
Closed

Conversation

pete-watters
Copy link
Contributor

This PR adds the collectibles widget using mock data

Area.mp4

@pete-watters pete-watters force-pushed the feat/222/collectibles-widget branch 5 times, most recently from c8e116a to 338a9ac Compare September 18, 2024 15:06
@pete-watters
Copy link
Contributor Author

Opening this for review but it has a known type error I need to solve

@pete-watters pete-watters force-pushed the feat/222/collectibles-widget branch 3 times, most recently from 9f835b5 to e87783d Compare September 19, 2024 10:12
@pete-watters
Copy link
Contributor Author

Opening this for review but it has a known type error I need to solve

Fixed

@pete-watters pete-watters force-pushed the feat/222/collectibles-widget branch 2 times, most recently from 2d95724 to 4be26d2 Compare September 19, 2024 10:22
@pete-watters pete-watters self-assigned this Sep 19, 2024
@edgarkhanzadian
Copy link
Collaborator

edgarkhanzadian commented Sep 19, 2024

I wonder what's the reason for it not going all the way to the right:

collectibles.mov

And i think we should also add "5" padding to the inside of the scrollview so that it doesn't stick to the end of the phone. You can do it with contentContainerStyles

@pete-watters
Copy link
Contributor Author

I wonder what's the reason for it not going all the way to the right:

collectibles.mov
And i think we should also add "5" padding to the inside of the scrollview so that it doesn't stick to the end of the phone. You can do it with contentContainerStyles

Thanks, let me check. I face the same issue with the scrollview on the Accounts widget. I tried adding a right margin but it didn't work. I will play with it and see if I can figure it out

I had padding but no margin and it wasn't going the full width of the screen: https://github.com/leather-io/issues/issues/322

The design has padding of 5
Screenshot 2024-09-19 at 15 00 47

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.39%. Comparing base (17b5a3c) to head (fbd6c7e).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #458   +/-   ##
=======================================
  Coverage   22.39%   22.39%           
=======================================
  Files         132      132           
  Lines        5519     5519           
  Branches      241      241           
=======================================
  Hits         1236     1236           
  Misses       4283     4283           
Components Coverage Δ
bitcoin 53.77% <ø> (ø)
query 12.06% <ø> (ø)
utils 52.45% <ø> (ø)
crypto 69.40% <ø> (ø)
stacks 53.27% <ø> (ø)

@pete-watters
Copy link
Contributor Author

I'm going to close this for now and spend more time investigating #458 (comment) and also moving the extension Collectible components to the monorepo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants