feat: settings notifications #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbwoolf
force-pushed
the
feat/settings-notifications
branch
2 times, most recently
from
c27b12a
to
02fde42
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #480 +/- ##
=======================================
Coverage 22.38% 22.38%
=======================================
Files 132 132
Lines 5521 5521
Branches 241 241
=======================================
Hits 1236 1236
Misses 4285 4285
|
|
|
||
| return ( | ||
| <Box flex={1} backgroundColor="ink.background-primary"> | ||
| <ScrollView |
There was a problem hiding this comment.
Not for this PR but we seem to repeat this <ScrollView with these props a lot (5 times). We could look into a layout for it?
There was a problem hiding this comment.
I forgot I created a SettingsScreenLayout to use here, so will do. Thx for reminder.
pete-watters
approved these changes
Sep 26, 2024
kyranjamie
reviewed
Sep 26, 2024
edgarkhanzadian
added
the
needs:demo-build
fbwoolf
force-pushed
the
feat/settings-notifications
branch
2 times, most recently
from
171db36
to
05e9656
Compare
fbwoolf
force-pushed
the
feat/settings-notifications
branch
from
05e9656
to
2355175
Compare
|
Updated the toast types here cc @fabric-8, also the copy on the success was to wordy so I simplified to fit on screen better...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements screens for settings notifications, adds tabs for 'push' and 'email' notifications, and uses an input to store a preferred email address to receive notifications.
I used zod to validate the email address. I'll need design feedback on what to show for an invalid email address, rn I'm showing a toast but we only have a
successandinfotypes currently. I think I need to add afailtype?