Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/ui-package-bundling #484

Merged
merged 2 commits into from
Sep 27, 2024
Merged

refactor/ui-package-bundling #484

merged 2 commits into from
Sep 27, 2024

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Sep 27, 2024

This PR fixes several issues with the bundling of the UI package targeting web. Was close to calling Mission Abort on this one, but eventually trial-and-errored a way to fixing the extension styles 😅

  • Native code no longer bundled into web-dist folder
  • Prevents double-bundling with tsup and tsc
  • Removes tsconfig settings causing default to absolute path imports
  • Moves export file into src folder
  • Adds export for UI lib styles

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.38%. Comparing base (498a1db) to head (84fe0a2).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #484   +/-   ##
=======================================
  Coverage   22.38%   22.38%           
=======================================
  Files         132      132           
  Lines        5521     5521           
  Branches      241      241           
=======================================
  Hits         1236     1236           
  Misses       4285     4285           
Components Coverage Δ
bitcoin 53.77% <ø> (ø)
query 12.05% <ø> (ø)
utils 52.45% <ø> (ø)
crypto 69.40% <ø> (ø)
stacks 53.27% <ø> (ø)

Copy link
Contributor

@fbwoolf fbwoolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great to see the iterations on this effort. 🚀

@kyranjamie kyranjamie added this pull request to the merge queue Sep 27, 2024
Merged via the queue into dev with commit b765ced Sep 27, 2024
13 checks passed
@kyranjamie kyranjamie deleted the refactor/ui branch September 27, 2024 12:40
@pete-watters
Copy link
Contributor

Great improvements, thanks for doing this 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants