Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): bns schemas, exports #618

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix(query): bns schemas, exports #618

merged 1 commit into from
Nov 13, 2024

Conversation

kyranjamie
Copy link
Collaborator

@alter-eggo tests were failing even though functionality worked because our mocked responses didn't conform to schema.

This PR exports all schemas as validators. When declaring mocks, let's do so with a schema.parse(mock), so we can verify they match.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 23.81%. Comparing base (6b72065) to head (53075a9).

Files with missing lines Patch % Lines
packages/query/src/stacks/bns/bns.schemas.ts 0.00% 4 Missing ⚠️
packages/query/index.ts 0.00% 1 Missing ⚠️
packages/query/src/stacks/bns/bns-v2-client.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #618      +/-   ##
==========================================
- Coverage   23.84%   23.81%   -0.03%     
==========================================
  Files         165      165              
  Lines        6148     6151       +3     
  Branches      335      335              
==========================================
- Hits         1466     1465       -1     
- Misses       4682     4686       +4     
Files with missing lines Coverage Δ
packages/query/src/query-prefixes.ts 100.00% <ø> (ø)
packages/query/index.ts 0.00% <0.00%> (ø)
packages/query/src/stacks/bns/bns-v2-client.ts 0.00% <0.00%> (ø)
packages/query/src/stacks/bns/bns.schemas.ts 0.00% <0.00%> (ø)
Components Coverage Δ
bitcoin 62.04% <ø> (ø)
query 12.73% <0.00%> (-0.04%) ⬇️
utils 48.31% <ø> (ø)
crypto 68.21% <ø> (ø)
stacks 54.71% <ø> (ø)

@kyranjamie kyranjamie added this pull request to the merge queue Nov 13, 2024
Merged via the queue into dev with commit 52fd74d Nov 13, 2024
11 checks passed
@kyranjamie kyranjamie deleted the fix/bns-schemas branch November 13, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants