cleanup/jslinter suppressions (#8234)

* Eliminate unused variable warnings Partially by moving to 'arrow functions'. * Remove airbnb style ruleset; lots of rules need temporary disabling (like 'class-methods-use-this') * Remove untriggered eslint suppressions * Fix shadowed variables * We don't like camelcase, so don't enforce it... * Suppress inner declaration errors for webpack.config.js * Remove unused variable * Remove errors that aren't fine-grained enough (e.g., we accept console in jest scripts) * Enable resolving vue-router * Fix infinite recursion
ledgersmb · Jun 1, 2024 · cb81ce3 · cb81ce3
1 parent 337b7f6
commit cb81ce3
Show file tree

Hide file tree

Showing 37 changed files with 65 additions and 176 deletions.
diff --git a/UI/__mocks__/dijit/registry.js b/UI/__mocks__/dijit/registry.js
@@ -1,17 +1,16 @@
-/* eslint-disable no-shadow */
 // Borrowed from dijit/registry to avoid pulling in all Dojo/Dijit
 
 const registry = Object.create(null);
 
 function findWidgets(root, skipNode) {
     var outAry = [];
 
-    function getChildrenHelper(root){
-        for(var node = root.firstChild; node; node = node.nextSibling){
-            if(node.getAttribute && node.getAttribute("widgetid")){
-                outAry.push(node);
-            }else if(node !== skipNode){
-                getChildrenHelper(node);
+    function getChildrenHelper (node) {
+        for(var el = node.firstChild; el; el = el.nextSibling){
+            if(el.getAttribute && el.getAttribute("widgetid")){
+                outAry.push(el);
+            }else if(el !== skipNode){
+                getChildrenHelper(el);
             }
         }
     }
@@ -22,4 +21,4 @@ function findWidgets(root, skipNode) {
 
 registry.findWidgets = findWidgets;
 
-module.exports = registry;
+module.exports = registry;
diff --git a/UI/js-src/lsmb/menus/Tree.js b/UI/js-src/lsmb/menus/Tree.js
@@ -61,7 +61,6 @@ define([
                 complete = true;
             }
         },
-        // eslint-disable-next-line no-unused-vars
         getRoot: function (onItem, onError) {
             onItem({ id: 0 });
         }

diff --git a/UI/js-src/lsmb/parts/PartDescription.js b/UI/js-src/lsmb/parts/PartDescription.js
@@ -30,7 +30,6 @@ define([
             channel: null,
             height: null,
             store: partRestStore,
-            /* eslint no-template-curly-in-string:0 */
             queryExpr: "*${0}*",
             autoComplete: false,
             highlightMatch: "all",
@@ -40,18 +39,16 @@ define([
             dropDownClass: _ComboBoxMenu,
             autoSizing: true,
             startup: function () {
-                var self = this;
                 this.inherited(arguments);
                 if (this.channel) {
                     this.own(
-                        topic.subscribe(this.channel, function (selected) {
-                            self.set("value", selected[self.searchAttr]);
+                        topic.subscribe(this.channel, (selected) => {
+                            this.set("value", selected[this.searchAttr]);
                         })
                     );
-                    // eslint-disable-next-line no-unused-vars
-                    this.on("change", function (newValue) {
-                        if (self.item) {
-                            topic.publish(self.channel, self.item);
+                    this.on("change", () => {
+                        if (this.item) {
+                            topic.publish(this.channel, this.item);
                         }
                     });
                 }

diff --git a/UI/js-src/lsmb/parts/PartSelector.js b/UI/js-src/lsmb/parts/PartSelector.js
@@ -24,17 +24,15 @@ define([
             this.initialValue = arguments[0].value;
         },
         startup: function () {
-            var self = this;
             this.inherited(arguments);
             if (this.channel) {
                 this.own(
-                    topic.subscribe(this.channel, function (selected) {
-                        self.set("value", selected[self.searchAttr]);
+                    topic.subscribe(this.channel, (selected) => {
+                        this.set("value", selected[this.searchAttr]);
                     })
                 );
-                // eslint-disable-next-line no-unused-vars
-                this.on("change", function (newValue) {
-                    topic.publish(self.channel, self.item);
+                this.on("change", () => {
+                    topic.publish(this.channel, this.item);
                 });
             }
         }

diff --git a/UI/js-src/lsmb/reports/ComparisonSelector.js b/UI/js-src/lsmb/reports/ComparisonSelector.js
@@ -26,33 +26,29 @@ define([
             channel: "",
             mode: "by-dates",
             postCreate: function () {
-                var self = this;
                 this.inherited(arguments);
                 this.own(
-                    topic.subscribe(this.channel, function (action, value) {
+                    topic.subscribe(this.channel, (action, value) => {
                         var display = "";
 
                         if (action === "changed-period-type") {
-                            self.mode = value;
+                            this.mode = value;
 
                             if (value === "by-dates") {
-                                display = self._comparison_periods.get("value");
+                                display = this._comparison_periods.get("value");
                             }
                         }
-                        self._update_display(display);
+                        this._update_display(display);
                     })
                 );
             },
             startup: function () {
-                var self = this;
-
                 this.inherited(arguments);
                 this._comparison_periods = registry.byId("comparison-periods");
                 this.own(
-                    // eslint-disable-next-line no-unused-vars
-                    on(this._comparison_periods, "change", function (newvalue) {
-                        self._update_display(
-                            self._comparison_periods.get("value")
+                    on(this._comparison_periods, "change", () => {
+                        this._update_display(
+                            this._comparison_periods.get("value")
                         );
                     })
                 );

diff --git a/UI/js-src/lsmb/users/ChangePassword.js b/UI/js-src/lsmb/users/ChangePassword.js
@@ -43,7 +43,6 @@ define([
                 return this.lstrings[toTranslate];
             },
             startup: function () {
-                // eslint-disable-next-line guard-for-in
                 for (var str in this._lstrings) {
                     if (this.lstrings[str]) {
                         continue;
@@ -106,7 +105,6 @@ define([
                     nonWords: /\W/.test(pass)
                 };
                 var variationCount = 0;
-                // eslint-disable-next-line guard-for-in
                 for (var check in variations) {
                     variationCount += variations[check] === true ? 1 : 0;
                 }
@@ -128,17 +126,16 @@ define([
                 domAttr.set("pw-strength", "innerHTML", score);
             },
             submitForm: function () {
-                var I = this;
                 var r = request;
-                var oldPassword = I.oldpw.get("value");
-                var newPassword = I.newpw.get("value");
-                var confirmedPassword = I.verified.get("value");
+                var oldPassword = this.oldpw.get("value");
+                var newPassword = this.newpw.get("value");
+                var confirmedPassword = this.verified.get("value");
                 if (oldPassword === "" || newPassword === "") {
-                    I.setFeedback(false, I.text("Password Required"));
+                    this.setFeedback(false, this.text("Password Required"));
                     return;
                 }
                 if (newPassword !== confirmedPassword) {
-                    I.setFeedback(false, I.text("Confirmation did not match"));
+                    this.setFeedback(false, this.text("Confirmation did not match"));
                     return;
                 }
                 r("user.pl", {
@@ -150,21 +147,20 @@ define([
                     },
                     method: "POST"
                 })
-                    // eslint-disable-next-line no-unused-vars
-                    .then(function (response) {
-                        I.setFeedback(true, I.text("Password Changed"));
+                    .then(() => {
+                        this.setFeedback(true, this.text("Password Changed"));
                     })
-                    .otherwise(function (err) {
+                    .otherwise((err) => {
                         if (err.response.status !== 200) {
                             if (err.response.status !== 500) {
-                                I.setFeedback(
+                                this.setFeedback(
                                     false,
-                                    I.text("Bad username/Password")
+                                    this.text("Bad username/Password")
                                 );
                             } else {
-                                I.setFeedback(
+                                this.setFeedback(
                                     false,
-                                    I.text("Error changing password.")
+                                    this.text("Error changing password.")
                                 );
                             }
                         }

diff --git a/UI/js-src/lsmb/webpack.loaderConfig.js b/UI/js-src/lsmb/webpack.loaderConfig.js
@@ -17,8 +17,7 @@
  */
 const path = require("path");
 
-// eslint-disable-next-line no-unused-vars
-function getConfig(env) {
+function getConfig( /* env */ ) {
     // env is set by the 'buildEnvironment' and/or 'environment' plugin options
     // (see webpack.config.js),
     // or by the code at the end of this file if using without webpack

diff --git a/UI/package.json b/UI/package.json
@@ -49,7 +49,7 @@
     "tapable": "2.2.1",
     "vue": "3.4.27",
     "vue-i18n": "9.13.1",
-    "vue-router": "4.3.2"
+    "vue-router": "^4.3.2"
   },
   "devDependencies": {
     "@babel/core": "7.24.6",
@@ -77,7 +77,6 @@
     "dojo-webpack-plugin": "3.0.6",
     "ejs-loader": "0.5.0",
     "eslint": "8.57.0",
-    "eslint-config-airbnb-base": "15.0.0",
     "eslint-config-eslint": "10.0.0",
     "eslint-config-prettier": "9.1.0",
     "eslint-import-resolver-webpack": "0.13.8",
@@ -203,8 +202,7 @@
         "rules": {
           "jest/prefer-expect-assertions": "off",
           "jest/no-commented-out-tests": "off",
-          "no-console": "off",
-          "camelcase": "off"
+          "no-console": "off"
         }
       },
       {
@@ -253,7 +251,6 @@
       "es6": true
     },
     "extends": [
-      "airbnb-base/legacy",
       "eslint:recommended",
       "plugin:import/errors",
       "plugin:import/warnings",
@@ -270,7 +267,6 @@
       "!__mocks__/**"
     ],
     "rules": {
-      "camelcase": "error",
       "compat/compat": "warn",
       "consistent-return": "error",
       "curly": [
@@ -280,11 +276,7 @@
       "dot-notation": "error",
       "eqeqeq": "error",
       "func-names": 0,
-      "global-require": "error",
-      "guard-for-in": "error",
       "new-cap": 0,
-      "no-alert": "error",
-      "no-console": "error",
       "no-continue": 0,
       "no-else-return": "error",
       "no-lonely-if": "error",
@@ -303,7 +295,10 @@
       "no-use-before-define": "error",
       "no-useless-escape": "error",
       "no-useless-return": "error",
-      "one-var": "error",
+      "one-var": [
+        "error",
+        "never"
+      ],
       "radix": "error",
       "spaced-comment": [
         "error",

diff --git a/UI/src/components/ServerUI.js b/UI/src/components/ServerUI.js
@@ -176,7 +176,6 @@ export default {
                 // the widgets. (it may take a bit for the new content to overwrite the old
                 // content...)
                 query("*", document.getElementById("maindiv")).forEach(
-                    /* eslint-disable no-param-reassign */
                     (n) => delete n._cssState
                 );
             } catch (e) {

diff --git a/UI/src/elements/lsmb-base-input.js b/UI/src/elements/lsmb-base-input.js
@@ -1,5 +1,4 @@
 /** @format */
-/* eslint-disable class-methods-use-this */
 
 import { LsmbDijit } from "@/elements/lsmb-dijit";
 

diff --git a/UI/src/elements/lsmb-button.js b/UI/src/elements/lsmb-button.js
@@ -1,5 +1,4 @@
 /** @format */
-/* eslint-disable class-methods-use-this */
 
 import { LsmbDijit } from "@/elements/lsmb-dijit";
 

diff --git a/UI/src/elements/lsmb-date.js b/UI/src/elements/lsmb-date.js
@@ -1,5 +1,4 @@
 /** @format */
-/* eslint-disable class-methods-use-this, max-classes-per-file */
 
 import { LsmbBaseInput } from "@/elements/lsmb-base-input";
 

diff --git a/UI/src/elements/lsmb-dijit.js b/UI/src/elements/lsmb-dijit.js
@@ -1,5 +1,4 @@
 /** @format */
-/* eslint-disable class-methods-use-this */
 
 export class LsmbDijit extends HTMLElement {
     dojoWidget = null;
@@ -21,7 +20,6 @@ export class LsmbDijit extends HTMLElement {
     }
 
     _collectProps() {
-        /* eslint-disable no-eval */
         let extra = this.hasAttribute("dojo-props")
             ? eval("({" + this.getAttribute("dojo-props") + "})")
             : {};

diff --git a/UI/src/elements/lsmb-password.js b/UI/src/elements/lsmb-password.js
@@ -1,5 +1,4 @@
 /** @format */
-/* eslint-disable class-methods-use-this */
 
 import { LsmbText } from "@/elements/lsmb-text";
 

diff --git a/UI/src/elements/lsmb-text.js b/UI/src/elements/lsmb-text.js
@@ -1,5 +1,4 @@
 /** @format */
-/* eslint-disable class-methods-use-this, max-classes-per-file */
 
 import { LsmbBaseInput } from "@/elements/lsmb-base-input";
 

diff --git a/UI/src/i18n.js b/UI/src/i18n.js
@@ -1,6 +1,4 @@
 /** @format */
-/* eslint-disable global-require */
-/* eslint-disable camelcase, prettier/prettier */
 
 const rtlDetect = require("rtl-detect");
 
@@ -14,7 +12,6 @@ function _mapLocale(locale) {
     return locale;
 }
 
-// eslint-disable-next-line import/no-unresolved
 import messages from '@/locales/en.json';
 import { nextTick } from "vue";
 
@@ -38,14 +35,14 @@ export async function setI18nLanguage(lang) {
             const _messages = await import(/* webpackChunkName: "lang-[request]" */ `@/locales/${locale}.json`);
             i18n.global.setLocaleMessage(locale, _messages.default);
         }
-        catch (e) {
+        catch {
             const strippedLocale = locale.replace(/_[a-z]+/i, '');
             try {
                 const _messages = await import(/* webpackChunkName: "lang-[request]" */ `@/locales/${strippedLocale}.json`);
                 i18n.global.setLocaleMessage(strippedLocale, _messages.default);
                 locale = strippedLocale;
             }
-            catch (f) {
+            catch {
                 locale = "en";
             }
         }

diff --git a/UI/src/main-vue.js b/UI/src/main-vue.js
@@ -1,5 +1,4 @@
 /** @format */
-/* eslint-disable no-console, import/no-unresolved, vue/multi-word-component-names */
 
 import { createApp } from "vue";
 import router from "@/router";
@@ -19,7 +18,6 @@ let appName;
 let lsmbDirective = {
     beforeMount(el, binding /* , vnode */) {
         let handler = (event) => {
-            /* eslint-disable no-param-reassign */
             binding.instance[binding.arg] = event.target.value;
         };
         el.addEventListener("input", handler);
@@ -37,8 +35,7 @@ if (document.getElementById("main")) {
         mounted() {
             window.__lsmbLoadLink = (url) =>
                 this.$router.push(
-                    // eslint-disable-next-line no-useless-escape
-                    url.replace(/^https?:\/\/(?:[^@\/]+)/, "")
+                    url.replace(/^https?:\/\/(?:[^@/]+)/, "")
                 );
 
             let m = document.getElementById("main");

diff --git a/UI/src/robot-vue.js b/UI/src/robot-vue.js
@@ -75,11 +75,9 @@ function contextRef(service, key) {
         typeof service.context[key] === typeof {}
     ) {
         const s = service;
-        // eslint-disable-next-line vue/no-ref-as-operand
         ref = reactive(service.context[key]);
         s.context[key] = ref;
     } else {
-        // eslint-disable-next-line vue/no-ref-as-operand
         ref = allocRef(service.context[key]);
     }
     const ctxRef = {