Transaction reversal tracking #6715

ehuelsmann · 2022-08-09T19:56:09Z

The reversal of the reversed transaction is to be exact (which is what ~~#2321~~ says is currently not happening). Part of this has been fixed earlier, but taxes are still being redone on reversal (for invoices), which means that the transactions cannot be exact before this PR.

Additionally, in order to be able to track what happened to transactions, it's important to see relations between transactions as they are created. To that purpose, this PR creates infrastructure to track which transactions or invoices have been reversed (voided) and which transactions are the reversing(voiding) ones. It also prevents a transaction from being voided twice.

The following functionalities are planned for this PR:

Item	AR	AP	GL	IS	IR
Tracking reversals ¹	✔️	✔️	✔️	✔️	✔️
Prevent duplicate reversals (shared)	✔️	✔️	✔️	✔️	✔️
Read-only UI on reversals	✔️	✔️	✔️	✔️	✔️
Editable headers only (reference/invnumber)	✔️	✔️	✔️	✔️	✔️
Editable headers only (sequence)	✔️	✔️	✔️	✔️	✔️
Editable headers only (date[s])	✔️	✔️	✔️	✔️	✔️
Editable headers only (description)	✔️	✔️	✔️	✔️	✔️
Editable headers only (notes)	✔️	✔️	✔️	✔️	✔️
Editable headers only (internal notes)	✔️	✔️	➖ ²	✔️	✔️

Additional functionality implemented in this PR:

Searching for reversed and voided GL/AR/AP transactions and AR/AP invoices

This change adds tracking to transactions like this:

A problem is that the triggering workflow advances to the next state (reversed/voided) even when the replacement transaction hasn't been posted yet. We need a mechanism to advance the transaction to VOIDED / REVERSED at the same time the reversal is posted. Until that happens, it'd be nice to help the user by listing the transaction as "in the process of being reversed. ↩
Not applicable ↩

ehuelsmann · 2022-08-10T21:57:56Z

Since the fix for #2321 has been released for 1.7, 1.8 and 1.9, the 'exact reversal' goal of this PR has been resolved. This PR was mostly initiated to address that problem (and improve on the situation of reversal tracking while at it).

old/bin/gl.pl

old/bin/aa.pl

ehuelsmann · 2022-08-28T22:03:07Z

old/bin/aa.pl

+            &create_links; # create_links overwrites 'reversing'
+        };
+
+        AA->post_transaction( \%myconfig, \%$form );


The unfortunate side-effect of this choice is that the transaction goes through all the logic of loading and posting a transaction instead of copying the original transaction and negating its effect. I'm looking for ideas on how to bypass the loading and saving to prevent "damage" to the exact (negated) copy.

ehuelsmann · 2022-10-14T14:26:19Z

old/bin/aa.pl

+               transdate = ?,
+               notes = ?
+         WHERE id = ?
+        QUERY


What's with this query? It's not being used?!

ehuelsmann · 2023-04-23T16:00:01Z

@christian-eriksson, @neilt, I can't add you to the list of reviewers, but your comments regarding this PR are highly appreciated!

ehuelsmann · 2023-04-24T05:44:57Z

@neilt notes:

ehuelsmann: I tested GL and the only anomaly I found was this:

Enter Journal Entry
Do Transaction Approval
Search for Transaction
Reverse Transaction
Done

Why when I have "Separate Duties" turned on do I have to approve the original GL Journal Entry, but the reversal happens immediately and does not have to be Approved?

neilt · 2023-04-24T14:44:38Z

When I try to reverse a AR Invoice with both a service and a part I get the following error.

I assume that it is the service that is causing the problem, but can't tell from the error message.

But it seems to have worked anyway, which was unexpected. Here is the completed reversal screen:

neilt · 2023-04-24T14:48:49Z

On the AR and AP search screen I would like to see a checkbox for Voided Invoices.

Not sure which lines it goes on (status or include in report). But I think being able to pull out recent voided invoices would be useful.

ehuelsmann · 2023-04-25T16:29:40Z

@neilt notes:

ehuelsmann: I tested GL and the only anomaly I found was this:
1. Enter Journal Entry

2. Do Transaction Approval

3. Search for Transaction

4. Reverse Transaction

5. Done
Why when I have "Separate Duties" turned on do I have to approve the original GL Journal Entry, but the reversal happens immediately and does not have to be Approved?

I'm unable to reproduce. Hoping that means it's no longer a problem... Can't fix it without reproduction recipe, is my main point though.

ehuelsmann · 2023-04-28T19:11:48Z

Not sure which lines it goes on (status or include in report). But I think being able to pull out recent voided invoices would be useful.

"Include in" is an output column with no influence on the selection. Your description suggests it's about filtering, which means it should go in the status column.

On transaction retrieval, also retrieve the new reversal related columns 'reversing' and 'reversed_by'. This works both for invoices and transactions.

Note that the regular term is a transaction whereas the reversing "thing" is a credit/debit note. The reverse of those are transactions again.

…footers

…voice...

ehuelsmann · 2023-04-29T18:14:01Z

When I try to reverse a AR Invoice with both a service and a part I get the following error.

Hmm. I'm unable to reproduce. Neither on master nor on the branch... I guess I'll need help or we need to declare it a heisenbug.

While at it, harmonize the AR/AP and GL search pages.

neilt · 2023-04-29T18:45:39Z

I'm fine with closing this PR. I'll open an issue if I can recreate the issue. I don't time to test it again right now.

ehuelsmann requested review from freelock and ylavoie August 9, 2022 19:56

ehuelsmann force-pushed the features/reversed-transactions branch 2 times, most recently from 2b286f0 to dac1740 Compare August 9, 2022 21:12

ehuelsmann changed the title ~~Transaction reversal tracking and reversal exactness~~ Transaction reversal tracking Aug 10, 2022

ehuelsmann force-pushed the features/reversed-transactions branch from dac1740 to 9031a0f Compare August 28, 2022 21:21

ehuelsmann commented Aug 28, 2022

View reviewed changes

ehuelsmann force-pushed the features/reversed-transactions branch 2 times, most recently from cddae6d to 682b80c Compare October 13, 2022 20:14

ehuelsmann commented Oct 14, 2022

View reviewed changes

old/bin/aa.pl

transdate = ?,

notes = ?

WHERE id = ?

QUERY

Copy link

Member Author

ehuelsmann Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with this query? It's not being used?!

ehuelsmann force-pushed the features/reversed-transactions branch from 61ae406 to 3b80297 Compare November 2, 2022 10:44

ehuelsmann force-pushed the features/reversed-transactions branch from 9dc64d5 to deba61d Compare December 24, 2022 21:34

ehuelsmann force-pushed the features/reversed-transactions branch from deba61d to cff626c Compare February 1, 2023 21:36

ehuelsmann force-pushed the features/reversed-transactions branch from cff626c to f5d09dc Compare February 18, 2023 20:50

ehuelsmann force-pushed the features/reversed-transactions branch from f5d09dc to 4910520 Compare March 7, 2023 22:36

ehuelsmann force-pushed the features/reversed-transactions branch from 4910520 to d40160d Compare April 4, 2023 20:43

ehuelsmann force-pushed the features/reversed-transactions branch 2 times, most recently from a8bb968 to 3bbb8ec Compare April 22, 2023 21:12

ehuelsmann marked this pull request as ready for review April 22, 2023 22:01

ehuelsmann requested a review from aungzwin10 April 22, 2023 22:02

ehuelsmann force-pushed the features/reversed-transactions branch from c6fd6e5 to 161c747 Compare April 25, 2023 16:18

ehuelsmann force-pushed the features/reversed-transactions branch from 5fe3704 to 721ca32 Compare April 29, 2023 08:13

Track reversal of GL transactions

defe17b

ehuelsmann added 13 commits April 29, 2023 20:10

Retrieve new reversal columns for AR/AP

cb2c3b2

On transaction retrieval, also retrieve the new reversal related columns 'reversing' and 'reversed_by'. This works both for invoices and transactions.

Reversal tracking and posting for AR/AP transactions

eedf997

Note that the regular term is a transaction whereas the reversing "thing" is a credit/debit note. The reverse of those are transactions again.

Mostly read-only interface for transaction reversal entry

9889a46

Address review comments regarding retention of "transdate"

355c545

Read-only rendering for reversing transactions

c4fbc21

Reversal tracking and posting for AR/AP invoices

d103ecb

Fixes from testing

180afd8

Readonly inputs for reversed transactions, except specific headers & …

9f67896

…footers

Readonly inputs for reversed invoices, except specific headers & footers

c6ab476

Add -VOID suffix to voiding invoices

fb08a38

Prevent readonly rendering of orders

09ddee0

Reversing a credit/debit invoice should result in a sales/purchase in…

b9490b8

…voice...

Save the reversal status for AR/AP/GL transactions

088adaf

Implement searching for voided transactions/invoices

a34e60a

While at it, harmonize the AR/AP and GL search pages.

ehuelsmann force-pushed the features/reversed-transactions branch from 721ca32 to a34e60a Compare April 29, 2023 18:16

ehuelsmann added 2 commits April 29, 2023 22:46

Mention reversed transactions by reference+ID instead of ID alone

e43b51f

On read-only lines, don't display the "delete line" button

1bd698b

ehuelsmann enabled auto-merge April 29, 2023 20:52

ehuelsmann merged commit cdd1334 into ledgersmb:master Apr 29, 2023

ehuelsmann deleted the features/reversed-transactions branch April 29, 2023 21:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transaction reversal tracking #6715

Transaction reversal tracking #6715

ehuelsmann commented Aug 9, 2022 •

edited

Loading

ehuelsmann commented Aug 10, 2022

ehuelsmann Aug 28, 2022

ehuelsmann Oct 14, 2022

ehuelsmann commented Apr 23, 2023

ehuelsmann commented Apr 24, 2023

neilt commented Apr 24, 2023

neilt commented Apr 24, 2023 •

edited

Loading

ehuelsmann commented Apr 25, 2023

ehuelsmann commented Apr 28, 2023

ehuelsmann commented Apr 29, 2023

neilt commented Apr 29, 2023

Transaction reversal tracking #6715

Transaction reversal tracking #6715

Conversation

ehuelsmann commented Aug 9, 2022 • edited Loading

Footnotes

ehuelsmann commented Aug 10, 2022

ehuelsmann Aug 28, 2022

Choose a reason for hiding this comment

ehuelsmann Oct 14, 2022

Choose a reason for hiding this comment

ehuelsmann commented Apr 23, 2023

ehuelsmann commented Apr 24, 2023

neilt commented Apr 24, 2023

neilt commented Apr 24, 2023 • edited Loading

ehuelsmann commented Apr 25, 2023

ehuelsmann commented Apr 28, 2023

ehuelsmann commented Apr 29, 2023

neilt commented Apr 29, 2023

ehuelsmann commented Aug 9, 2022 •

edited

Loading

neilt commented Apr 24, 2023 •

edited

Loading