-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralization of some OpenAPI docs #7386
Centralization of some OpenAPI docs #7386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openapi & info sections in Invoices should be checked too.
@ylavoie this one is actually intentional: Invoices isn't using the DSL keywords from the router to declare API entrypoints (yet). Which makes it different from the others in that it uses its own OpenAPI validator instead of the one from Router.pm. You're right, however, that this should be changed. I'll have a look at how difficult it is to change this. |
@ylavoie i think I can fix https://github.com/ledgersmb/LedgerSMB/actions/runs/4913494760/jobs/8773795061?pr=7386#step:19:330 by overriding discount to be a float instead of a bigfloat. Or should we change the schema? |
0bae2ac
to
4af7709
Compare
And at the same time add more documentation (instead of tripple dots)
The 'openapi:' header has moved to LedgerSMB::Routes::ERP::API, because of the centralization of common components. Implement a different criterion to extract data sections.
4af7709
to
7ff4d2e
Compare
Requested change was left unchanged intentionally.
And at the same time add more documentation (instead of tripple dots)