Centralization of some OpenAPI docs #7386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylavoie
previously requested changes
May 8, 2023
@ylavoie this one is actually intentional: Invoices isn't using the DSL keywords from the router to declare API entrypoints (yet). Which makes it different from the others in that it uses its own OpenAPI validator instead of the one from Router.pm. You're right, however, that this should be changed. I'll have a look at how difficult it is to change this. |
|
@ylavoie i think I can fix https://github.com/ledgersmb/LedgerSMB/actions/runs/4913494760/jobs/8773795061?pr=7386#step:19:330 by overriding discount to be a float instead of a bigfloat. Or should we change the schema? |
ehuelsmann
force-pushed
the
cleanup/api-docs-deduplication
branch
2 times, most recently
from
0bae2ac
to
4af7709
Compare
And at the same time add more documentation (instead of tripple dots)
The 'openapi:' header has moved to LedgerSMB::Routes::ERP::API, because of the centralization of common components. Implement a different criterion to extract data sections.
ehuelsmann
force-pushed
the
cleanup/api-docs-deduplication
branch
from
4af7709
to
7ff4d2e
Compare
ehuelsmann
dismissed
ylavoie’s stale review
Requested change was left unchanged intentionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And at the same time add more documentation (instead of tripple dots)